| Message ID | 20230523075331.32250-11-guoqing.jiang@linux.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | misc patches for rnbd | expand |
On Tue, May 23, 2023 at 9:53 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote: > > Both rnbd-srv and rnbd-clt set it with 'clt', which is not > clear, let's change them to 'clt' and 'srv' accordingly. The "ctl" means "control" here, it contains some writable knobs.. And this change will break user space tools, so NAK for this one, others looks good, will reply separately. > Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> NAK, please drop it. Thx! > --- > drivers/block/rnbd/rnbd-clt-sysfs.c | 2 +- > drivers/block/rnbd/rnbd-srv-sysfs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c > index a0b49a0c0bdd..f6e2b075d2d5 100644 > --- a/drivers/block/rnbd/rnbd-clt-sysfs.c > +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c > @@ -652,7 +652,7 @@ int rnbd_clt_create_sysfs_files(void) > > rnbd_dev = device_create_with_groups(rnbd_dev_class, NULL, > MKDEV(0, 0), NULL, > - default_attr_groups, "ctl"); > + default_attr_groups, "clt"); > if (IS_ERR(rnbd_dev)) { > err = PTR_ERR(rnbd_dev); > goto cls_destroy; > diff --git a/drivers/block/rnbd/rnbd-srv-sysfs.c b/drivers/block/rnbd/rnbd-srv-sysfs.c > index 4962826e9639..f17a4085dfbb 100644 > --- a/drivers/block/rnbd/rnbd-srv-sysfs.c > +++ b/drivers/block/rnbd/rnbd-srv-sysfs.c > @@ -219,7 +219,7 @@ int rnbd_srv_create_sysfs_files(void) > return PTR_ERR(rnbd_dev_class); > > rnbd_dev = device_create(rnbd_dev_class, NULL, > - MKDEV(0, 0), NULL, "ctl"); > + MKDEV(0, 0), NULL, "srv"); > if (IS_ERR(rnbd_dev)) { > err = PTR_ERR(rnbd_dev); > goto cls_destroy; > -- > 2.35.3 >
On 5/23/23 17:18, Jinpu Wang wrote: > On Tue, May 23, 2023 at 9:53 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote: >> Both rnbd-srv and rnbd-clt set it with 'clt', which is not >> clear, let's change them to 'clt' and 'srv' accordingly. > The "ctl" means "control" here, it contains some writable knobs.. > > And this change will break user space tools, so NAK for this one, > others looks good, will reply separately. > >> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> > NAK, please drop it. Sure, thanks for explanation! Guoqing
diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c index a0b49a0c0bdd..f6e2b075d2d5 100644 --- a/drivers/block/rnbd/rnbd-clt-sysfs.c +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c @@ -652,7 +652,7 @@ int rnbd_clt_create_sysfs_files(void) rnbd_dev = device_create_with_groups(rnbd_dev_class, NULL, MKDEV(0, 0), NULL, - default_attr_groups, "ctl"); + default_attr_groups, "clt"); if (IS_ERR(rnbd_dev)) { err = PTR_ERR(rnbd_dev); goto cls_destroy; diff --git a/drivers/block/rnbd/rnbd-srv-sysfs.c b/drivers/block/rnbd/rnbd-srv-sysfs.c index 4962826e9639..f17a4085dfbb 100644 --- a/drivers/block/rnbd/rnbd-srv-sysfs.c +++ b/drivers/block/rnbd/rnbd-srv-sysfs.c @@ -219,7 +219,7 @@ int rnbd_srv_create_sysfs_files(void) return PTR_ERR(rnbd_dev_class); rnbd_dev = device_create(rnbd_dev_class, NULL, - MKDEV(0, 0), NULL, "ctl"); + MKDEV(0, 0), NULL, "srv"); if (IS_ERR(rnbd_dev)) { err = PTR_ERR(rnbd_dev); goto cls_destroy;
Both rnbd-srv and rnbd-clt set it with 'clt', which is not clear, let's change them to 'clt' and 'srv' accordingly. Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> --- drivers/block/rnbd/rnbd-clt-sysfs.c | 2 +- drivers/block/rnbd/rnbd-srv-sysfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)