| Message ID | fed5b15691283ce72ceb9fb074f953c5da0f6852.1684856632.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix pca954x i2c-mux node names | expand |
On Tue, May 23, 2023 at 05:50:21PM +0200, Geert Uytterhoeven wrote: > "make dtbs_check": > > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: i2c-switch@70: $nodename:0: 'i2c-switch@70' does not match '^(i2c-?)?mux' > From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: i2c-switch@70: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c@0', 'i2c@1', 'i2c@2' were unexpected) > From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > ... > > Fix this by renaming PCA954x nodes to "i2c-mux", to match the I2C bus > multiplexer/switch DT bindings and the Generic Names Recommendation in > the Devicetree Specification. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Andrew Lunn <andrew@lunn.ch> writes: > On Tue, May 23, 2023 at 05:50:21PM +0200, Geert Uytterhoeven wrote: >> "make dtbs_check": >> >> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: i2c-switch@70: $nodename:0: 'i2c-switch@70' does not match '^(i2c-?)?mux' >> From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml >> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: i2c-switch@70: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c@0', 'i2c@1', 'i2c@2' were unexpected) >> From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml >> ... >> >> Fix this by renaming PCA954x nodes to "i2c-mux", to match the I2C bus >> multiplexer/switch DT bindings and the Generic Names Recommendation in >> the Devicetree Specification. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Andrew Applied on mvebu/dt64 Thanks, Gregory
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi index ca1aeb69a8929931..c864df9ec84d1b6f 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -135,7 +135,7 @@ &cp0_i2c1 { pinctrl-0 = <&cp0_i2c1_pins>; status = "okay"; - i2c-switch@70 { + i2c-mux@70 { compatible = "nxp,pca9548"; #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts index eb04735039362373..42a60f3dd5d142fc 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts @@ -285,7 +285,7 @@ &cp0_i2c1 { pinctrl-0 = <&cp0_i2c1_pins>; status = "okay"; - i2c-switch@70 { + i2c-mux@70 { compatible = "nxp,pca9544"; #address-cells = <1>; #size-cells = <0>;
"make dtbs_check": arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: i2c-switch@70: $nodename:0: 'i2c-switch@70' does not match '^(i2c-?)?mux' From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb: i2c-switch@70: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c@0', 'i2c@1', 'i2c@2' were unexpected) From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml ... Fix this by renaming PCA954x nodes to "i2c-mux", to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- v2: - Add Reviewed-by. --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +- arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)