| Message ID | 20230523074701.293502-1-dlemoal@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 401f8ef3193f9e3bbd454023152868c9aca6dc9d |
| Headers | show |
| Series | ata: libata-scsi: fix ata_msense_control kdoc comment | expand |
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On Tue, May 23, 2023 at 04:47:01PM +0900, Damien Le Moal wrote: > Add missing description of the spg argument of ata_msense_control(). > > Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation") > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/ata/libata-scsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index 69fc0d2c2123..40d6703e2d07 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct ata_queued_cmd *qc, > /** > * ata_mselect_control - Simulate MODE SELECT for control page > * @qc: Storage for translated ATA taskfile > + * @spg: target sub-page of the control page > * @buf: input buffer > * @len: number of valid bytes in the input buffer > * @fp: out parameter for the failed field on error > -- > 2.40.1 > Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
Damien,
> Add missing description of the spg argument of ata_msense_control().
Applied to 6.5/scsi-staging, thanks!
On Tue, 23 May 2023 16:47:01 +0900, Damien Le Moal wrote: > Add missing description of the spg argument of ata_msense_control(). > > Applied to 6.5/scsi-queue, thanks! [1/1] ata: libata-scsi: fix ata_msense_control kdoc comment https://git.kernel.org/mkp/scsi/c/401f8ef3193f
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 69fc0d2c2123..40d6703e2d07 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct ata_queued_cmd *qc, /** * ata_mselect_control - Simulate MODE SELECT for control page * @qc: Storage for translated ATA taskfile + * @spg: target sub-page of the control page * @buf: input buffer * @len: number of valid bytes in the input buffer * @fp: out parameter for the failed field on error
Add missing description of the spg argument of ata_msense_control(). Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation") Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/ata/libata-scsi.c | 1 + 1 file changed, 1 insertion(+)