| Message ID | 20230524083913.696175-2-marcin.juszkiewicz@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] hw/arm/sbsa-ref: honor "-vga none" argument | expand |
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: > Creation of network card is guarded with check do we > have pci bus. Do the same with graphics card. > > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > --- > hw/arm/sbsa-ref.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c > index c540b2f1ba..9a3d77d6b6 100644 > --- a/hw/arm/sbsa-ref.c > +++ b/hw/arm/sbsa-ref.c > @@ -647,10 +647,10 @@ static void create_pcie(SBSAMachineState *sms) > > pci_nic_init_nofail(nd, pci->bus, nd->model, NULL); > } > - } > > - if (vga_interface_type != VGA_NONE) { > - pci_create_simple(pci->bus, -1, "bochs-display"); > + if (vga_interface_type != VGA_NONE) { > + pci_create_simple(pci->bus, -1, "bochs-display"); > + } > } > > create_smmu(sms, pci->bus); I wonder whether pci->bus can ever be NULL in this function? Anyway: Reviewed-by: Thomas Huth <thuth@redhat.com>
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: > Creation of network card is guarded with check do we > have pci bus. Do the same with graphics card. > > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > --- > hw/arm/sbsa-ref.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c > index c540b2f1ba..9a3d77d6b6 100644 > --- a/hw/arm/sbsa-ref.c > +++ b/hw/arm/sbsa-ref.c > @@ -647,10 +647,10 @@ static void create_pcie(SBSAMachineState *sms) > > pci_nic_init_nofail(nd, pci->bus, nd->model, NULL); > } > - } > > - if (vga_interface_type != VGA_NONE) { > - pci_create_simple(pci->bus, -1, "bochs-display"); > + if (vga_interface_type != VGA_NONE) { > + pci_create_simple(pci->bus, -1, "bochs-display"); > + } > } I wonder whether pci->bus can ever be NULL in this function? Anyway: Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index c540b2f1ba..9a3d77d6b6 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -647,10 +647,10 @@ static void create_pcie(SBSAMachineState *sms) pci_nic_init_nofail(nd, pci->bus, nd->model, NULL); } - } - if (vga_interface_type != VGA_NONE) { - pci_create_simple(pci->bus, -1, "bochs-display"); + if (vga_interface_type != VGA_NONE) { + pci_create_simple(pci->bus, -1, "bochs-display"); + } } create_smmu(sms, pci->bus);
Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)