| Message ID | 20230523142912.2086985-1-lukma@denx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | dsa: marvell: Add support for mv88e6071 and 6020 switches | expand |
On Tue, May 23, 2023 at 04:29:09PM +0200, Lukasz Majewski wrote: > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, 6250, 6290" the > error when mv88e6020 or mv88e6071 is used is not present anymore. > dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC > family Hi Lukasz commit 7e9517375a14f44ee830ca1c3278076dd65fcc8f Author: Vladimir Oltean <vladimir.oltean@nxp.com> Date: Tue Mar 14 20:24:05 2023 +0200 net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, 6250, 6290 There are 3 classes of switch families that the driver is aware of, as far as mv88e6xxx_change_mtu() is concerned: - MTU configuration is available per port. Here, the chip->info->ops->port_set_jumbo_size() method will be present. - MTU configuration is global to the switch. Here, the chip->info->ops->set_max_frame_size() method will be present. - We don't know how to change the MTU. Here, none of the above methods will be present. Switch families MV88E6165, MV88E6191, MV88E6220, MV88E6250 and MV88E6290 fall in category 3. Vladimir indicates here that it is not known how to change the max MTU for the MV88E6250. Where did you get the information from to implement it? Andrew
Hi Andrew, > On Tue, May 23, 2023 at 04:29:09PM +0200, Lukasz Majewski wrote: > > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); > > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, > > 6250, 6290" the error when mv88e6020 or mv88e6071 is used is not > > present anymore. > > > dsa: marvell: Define .set_max_frame_size() function for mv88e6250 > > SoC family > > Hi Lukasz > > commit 7e9517375a14f44ee830ca1c3278076dd65fcc8f > Author: Vladimir Oltean <vladimir.oltean@nxp.com> > Date: Tue Mar 14 20:24:05 2023 +0200 > > net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, > 6250, 6290 > There are 3 classes of switch families that the driver is aware > of, as far as mv88e6xxx_change_mtu() is concerned: > > - MTU configuration is available per port. Here, the > chip->info->ops->port_set_jumbo_size() method will be present. > > - MTU configuration is global to the switch. Here, the > chip->info->ops->set_max_frame_size() method will be present. > > - We don't know how to change the MTU. Here, none of the above > methods will be present. > > Switch families MV88E6165, MV88E6191, MV88E6220, MV88E6250 and > MV88E6290 fall in category 3. > > > Vladimir indicates here that it is not known how to change the max MTU > for the MV88E6250. Where did you get the information from to implement > it? Please refer to [1]. The mv88e6185_g1_set_max_frame_size() function can be reused (as registers' offsets and bits are the same for mv88e60{71|20}). After using Vladimir's patch there is no need to add max_frame size field and related patches from v6 can be dropped. > > Andrew Links: [1] - https://www.spinics.net/lists/kernel/msg4798861.html Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Wed, May 24, 2023 at 02:17:43PM +0200, Lukasz Majewski wrote: > Hi Andrew, > > > On Tue, May 23, 2023 at 04:29:09PM +0200, Lukasz Majewski wrote: > > > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); > > > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, > > > 6250, 6290" the error when mv88e6020 or mv88e6071 is used is not > > > present anymore. > > > > > dsa: marvell: Define .set_max_frame_size() function for mv88e6250 > > > SoC family > > > > Hi Lukasz > > > > commit 7e9517375a14f44ee830ca1c3278076dd65fcc8f > > Author: Vladimir Oltean <vladimir.oltean@nxp.com> > > Date: Tue Mar 14 20:24:05 2023 +0200 > > > > net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, > > 6250, 6290 > > There are 3 classes of switch families that the driver is aware > > of, as far as mv88e6xxx_change_mtu() is concerned: > > > > - MTU configuration is available per port. Here, the > > chip->info->ops->port_set_jumbo_size() method will be present. > > > > - MTU configuration is global to the switch. Here, the > > chip->info->ops->set_max_frame_size() method will be present. > > > > - We don't know how to change the MTU. Here, none of the above > > methods will be present. > > > > Switch families MV88E6165, MV88E6191, MV88E6220, MV88E6250 and > > MV88E6290 fall in category 3. > > > > > > Vladimir indicates here that it is not known how to change the max MTU > > for the MV88E6250. Where did you get the information from to implement > > it? > > Please refer to [1]. > > The mv88e6185_g1_set_max_frame_size() function can be reused (as > registers' offsets and bits are the same for mv88e60{71|20}). > > After using Vladimir's patch there is no need to add max_frame size > field and related patches from v6 can be dropped. However, you haven't responded to: https://lore.kernel.org/all/ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk/ to explain why what you're doing (adding this function) is safe. Thanks.
> > Vladimir indicates here that it is not known how to change the max MTU > > for the MV88E6250. Where did you get the information from to implement > > it? > > Please refer to [1]. > > The mv88e6185_g1_set_max_frame_size() function can be reused (as > registers' offsets and bits are the same for mv88e60{71|20}). So you have the datasheet? You get the information to implement this from the data sheet? Andrew
Dear All, > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, 6250, > 6290" the error when mv88e6020 or mv88e6071 is used is not present > anymore. > Are there any more comments for this patch set? > As a result patches for adding max frame size are not required to > provide working setup with aforementioned switches. > > Lukasz Majewski (2): > dsa: marvell: Define .set_max_frame_size() function for mv88e6250 > SoC family > net: dsa: mv88e6xxx: add support for MV88E6071 switch > > Matthias Schiffer (1): > net: dsa: mv88e6xxx: add support for MV88E6020 switch > > drivers/net/dsa/mv88e6xxx/chip.c | 41 > ++++++++++++++++++++++++++++++++ drivers/net/dsa/mv88e6xxx/chip.h | > 2 ++ drivers/net/dsa/mv88e6xxx/port.h | 2 ++ > 3 files changed, 45 insertions(+) > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hello Lukasz, On Mon, May 29, 2023 at 11:02:22AM +0200, Lukasz Majewski wrote: > Dear All, > > > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); > > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, 6250, > > 6290" the error when mv88e6020 or mv88e6071 is used is not present > > anymore. > > > > Are there any more comments for this patch set? Has your email client eaten these comments too? https://lore.kernel.org/netdev/c39f4127-e1fe-4d38-83eb-f372ca2ebcd3@lunn.ch/ | On Wed, May 24, 2023 at 03:48:02PM +0200, Andrew Lunn wrote: | > > > Vladimir indicates here that it is not known how to change the max MTU | > > > for the MV88E6250. Where did you get the information from to implement | > > > it? | > > | > > Please refer to [1]. | > > | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as | > > registers' offsets and bits are the same for mv88e60{71|20}). | > | > So you have the datasheet? You get the information to implement this | > from the data sheet? | > | > Andrew https://lore.kernel.org/netdev/ZG4E+wd03cKipsib@shell.armlinux.org.uk/ | On Wed, May 24, 2023 at 01:37:15PM +0100, Russell King (Oracle) wrote: | > On Wed, May 24, 2023 at 02:17:43PM +0200, Lukasz Majewski wrote: | > > Please refer to [1]. | > > | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as | > > registers' offsets and bits are the same for mv88e60{71|20}). | > > | > > After using Vladimir's patch there is no need to add max_frame size | > > field and related patches from v6 can be dropped. | > | > However, you haven't responded to: | > | > https://lore.kernel.org/all/ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk/ | > | > to explain why what you're doing (adding this function) is safe. | > | > Thanks. | > | > -- | > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ | > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Hi Vladimir, > Hello Lukasz, > > On Mon, May 29, 2023 at 11:02:22AM +0200, Lukasz Majewski wrote: > > Dear All, > > > > > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); > > > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, > > > 6250, 6290" the error when mv88e6020 or mv88e6071 is used is not > > > present anymore. > > > > > > > Are there any more comments for this patch set? > > Has your email client eaten these comments too? > > https://lore.kernel.org/netdev/c39f4127-e1fe-4d38-83eb-f372ca2ebcd3@lunn.ch/ > | On Wed, May 24, 2023 at 03:48:02PM +0200, Andrew Lunn wrote: > | > > > Vladimir indicates here that it is not known how to change > the max MTU | > > > for the MV88E6250. Where did you get the > information from to implement | > > > it? > | > > > | > > Please refer to [1]. > | > > > | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as > | > > registers' offsets and bits are the same for mv88e60{71|20}). > | > > | > So you have the datasheet? You get the information to implement > this | > from the data sheet? > | > This I've replied to Andrew in a private mail. > | > Andrew > > https://lore.kernel.org/netdev/ZG4E+wd03cKipsib@shell.armlinux.org.uk/ > | On Wed, May 24, 2023 at 01:37:15PM +0100, Russell King (Oracle) > wrote: | > On Wed, May 24, 2023 at 02:17:43PM +0200, Lukasz Majewski > wrote: | > > Please refer to [1]. > | > > > | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as > | > > registers' offsets and bits are the same for mv88e60{71|20}). > | > > > | > > After using Vladimir's patch there is no need to add max_frame > size | > > field and related patches from v6 can be dropped. > | > > | > However, you haven't responded to: > | > > | > > https://lore.kernel.org/all/ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk/ | > > | > to explain why what you're doing (adding this function) is safe. > | > > | > Thanks. > | > The above question has been replied: https://lore.kernel.org/all/20230524145357.3928f261@wsk/ > | > -- > | > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > | > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! Do you have any more comments? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Mon, May 29, 2023 at 01:03:14PM +0200, Lukasz Majewski wrote: > This I've replied to Andrew in a private mail. Aha. > The above question has been replied: > https://lore.kernel.org/all/20230524145357.3928f261@wsk/ > > Do you have any more comments? I don't have any comments.
On Mon, May 29, 2023 at 02:23:34PM +0300, Vladimir Oltean wrote: > On Mon, May 29, 2023 at 01:03:14PM +0200, Lukasz Majewski wrote: > > This I've replied to Andrew in a private mail. > > Aha. Yes, the appropriate checks have been made, the reuse of the functions to set the MTU should be correct. Andrew
After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f); "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, 6250, 6290" the error when mv88e6020 or mv88e6071 is used is not present anymore. As a result patches for adding max frame size are not required to provide working setup with aforementioned switches. Lukasz Majewski (2): dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC family net: dsa: mv88e6xxx: add support for MV88E6071 switch Matthias Schiffer (1): net: dsa: mv88e6xxx: add support for MV88E6020 switch drivers/net/dsa/mv88e6xxx/chip.c | 41 ++++++++++++++++++++++++++++++++ drivers/net/dsa/mv88e6xxx/chip.h | 2 ++ drivers/net/dsa/mv88e6xxx/port.h | 2 ++ 3 files changed, 45 insertions(+)