mbox series

[v3,0/6] Bug fixes for net/handshake

Message ID 168381978252.84244.1933636428135211300.stgit@91.116.238.104.host.secureserver.net (mailing list archive)
Headers show
Series Bug fixes for net/handshake | expand

Message

Chuck Lever May 11, 2023, 3:46 p.m. UTC
Please consider these for merge via net-next.

Paolo observed that there is a possible leak of sock->file. I
haven't looked into that yet, but it seems to be separate from
the fixes in this series, so no need to hold these up.

Changes since v2:
- Address Paolo comment regarding handshake_dup()

Changes since v1:
- Rework "Fix handshake_dup() ref counting"
- Unpin sock->file when a handshake is cancelled

---

Chuck Lever (6):
      net/handshake: Remove unneeded check from handshake_dup()
      net/handshake: Fix handshake_dup() ref counting
      net/handshake: Fix uninitialized local variable
      net/handshake: handshake_genl_notify() shouldn't ignore @flags
      net/handshake: Unpin sock->file if a handshake is cancelled
      net/handshake: Enable the SNI extension to work properly


 Documentation/netlink/specs/handshake.yaml |  4 ++++
 Documentation/networking/tls-handshake.rst |  5 +++++
 include/net/handshake.h                    |  1 +
 include/uapi/linux/handshake.h             |  1 +
 net/handshake/handshake.h                  |  1 +
 net/handshake/netlink.c                    | 12 +++++-------
 net/handshake/request.c                    |  4 ++++
 net/handshake/tlshd.c                      |  8 ++++++++
 8 files changed, 29 insertions(+), 7 deletions(-)

--
Chuck Lever

Comments

patchwork-bot+netdevbpf@kernel.org May 12, 2023, 8:30 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 11 May 2023 11:46:39 -0400 you wrote:
> Please consider these for merge via net-next.
> 
> Paolo observed that there is a possible leak of sock->file. I
> haven't looked into that yet, but it seems to be separate from
> the fixes in this series, so no need to hold these up.
> 
> Changes since v2:
> - Address Paolo comment regarding handshake_dup()
> 
> [...]

Here is the summary with links:
  - [v3,1/6] net/handshake: Remove unneeded check from handshake_dup()
    https://git.kernel.org/netdev/net-next/c/b16d76fe9a27
  - [v3,2/6] net/handshake: Fix handshake_dup() ref counting
    https://git.kernel.org/netdev/net-next/c/2200c1a87074
  - [v3,3/6] net/handshake: Fix uninitialized local variable
    https://git.kernel.org/netdev/net-next/c/7301034026d0
  - [v3,4/6] net/handshake: handshake_genl_notify() shouldn't ignore @flags
    https://git.kernel.org/netdev/net-next/c/e36a93e1723e
  - [v3,5/6] net/handshake: Unpin sock->file if a handshake is cancelled
    https://git.kernel.org/netdev/net-next/c/f921bd41001c
  - [v3,6/6] net/handshake: Enable the SNI extension to work properly
    https://git.kernel.org/netdev/net-next/c/eefca7ec5142

You are awesome, thank you!
patchwork-bot+netdevbpf@kernel.org May 25, 2023, 5:20 a.m. UTC | #2
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 11 May 2023 11:46:39 -0400 you wrote:
> Please consider these for merge via net-next.
> 
> Paolo observed that there is a possible leak of sock->file. I
> haven't looked into that yet, but it seems to be separate from
> the fixes in this series, so no need to hold these up.
> 
> Changes since v2:
> - Address Paolo comment regarding handshake_dup()
> 
> [...]

Here is the summary with links:
  - [v3,1/6] net/handshake: Remove unneeded check from handshake_dup()
    https://git.kernel.org/netdev/net/c/a095326e2c0f
  - [v3,2/6] net/handshake: Fix handshake_dup() ref counting
    https://git.kernel.org/netdev/net/c/7ea9c1ec66bc
  - [v3,3/6] net/handshake: Fix uninitialized local variable
    https://git.kernel.org/netdev/net/c/7afc6d0a107f
  - [v3,4/6] net/handshake: handshake_genl_notify() shouldn't ignore @flags
    https://git.kernel.org/netdev/net/c/fc490880e39d
  - [v3,5/6] net/handshake: Unpin sock->file if a handshake is cancelled
    https://git.kernel.org/netdev/net/c/1ce77c998f04
  - [v3,6/6] net/handshake: Enable the SNI extension to work properly
    https://git.kernel.org/netdev/net/c/26fb5480a27d

You are awesome, thank you!