| Message ID | 20230528140001.1057084-4-adrian.larumbe@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Neil Armstrong |
| Headers | show |
| Series | Add additional YUV420 bus format check for dw-meson's bridge enable | expand |
Il 28/05/23 16:00, Adrián Larumbe ha scritto: I agree that the title almost says it all, but please add a commit description. Regards, Angelo > Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 ++++------------------ > 1 file changed, 4 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 1afb8f2603a0..0accfb51509c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -49,20 +49,6 @@ > > #define HDMI14_MAX_TMDSCLK 340000000 > > -enum hdmi_datamap { > - RGB444_8B = 0x01, > - RGB444_10B = 0x03, > - RGB444_12B = 0x05, > - RGB444_16B = 0x07, > - YCbCr444_8B = 0x09, > - YCbCr444_10B = 0x0B, > - YCbCr444_12B = 0x0D, > - YCbCr444_16B = 0x0F, > - YCbCr422_8B = 0x16, > - YCbCr422_10B = 0x14, > - YCbCr422_12B = 0x12, > -}; > - > static const u16 csc_coeff_default[3][4] = { > { 0x2000, 0x0000, 0x0000, 0x0000 }, > { 0x0000, 0x2000, 0x0000, 0x0000 }, > @@ -856,10 +842,10 @@ static void dw_hdmi_gp_audio_enable(struct dw_hdmi *hdmi) > > if (pdata->enable_audio) > pdata->enable_audio(hdmi, > - hdmi->channels, > - hdmi->sample_width, > - hdmi->sample_rate, > - hdmi->sample_non_pcm); > + hdmi->channels, > + hdmi->sample_width, > + hdmi->sample_rate, > + hdmi->sample_non_pcm); > } > > static void dw_hdmi_gp_audio_disable(struct dw_hdmi *hdmi)
On 28/05/2023 16:00, Adrián Larumbe wrote: > Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 ++++------------------ > 1 file changed, 4 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 1afb8f2603a0..0accfb51509c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -49,20 +49,6 @@ > > #define HDMI14_MAX_TMDSCLK 340000000 > > -enum hdmi_datamap { > - RGB444_8B = 0x01, > - RGB444_10B = 0x03, > - RGB444_12B = 0x05, > - RGB444_16B = 0x07, > - YCbCr444_8B = 0x09, > - YCbCr444_10B = 0x0B, > - YCbCr444_12B = 0x0D, > - YCbCr444_16B = 0x0F, > - YCbCr422_8B = 0x16, > - YCbCr422_10B = 0x14, > - YCbCr422_12B = 0x12, > -}; > - > static const u16 csc_coeff_default[3][4] = { > { 0x2000, 0x0000, 0x0000, 0x0000 }, > { 0x0000, 0x2000, 0x0000, 0x0000 }, > @@ -856,10 +842,10 @@ static void dw_hdmi_gp_audio_enable(struct dw_hdmi *hdmi) > > if (pdata->enable_audio) > pdata->enable_audio(hdmi, > - hdmi->channels, > - hdmi->sample_width, > - hdmi->sample_rate, > - hdmi->sample_non_pcm); > + hdmi->channels, > + hdmi->sample_width, > + hdmi->sample_rate, > + hdmi->sample_non_pcm); > } > > static void dw_hdmi_gp_audio_disable(struct dw_hdmi *hdmi) With proper commit description: Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 1afb8f2603a0..0accfb51509c 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -49,20 +49,6 @@ #define HDMI14_MAX_TMDSCLK 340000000 -enum hdmi_datamap { - RGB444_8B = 0x01, - RGB444_10B = 0x03, - RGB444_12B = 0x05, - RGB444_16B = 0x07, - YCbCr444_8B = 0x09, - YCbCr444_10B = 0x0B, - YCbCr444_12B = 0x0D, - YCbCr444_16B = 0x0F, - YCbCr422_8B = 0x16, - YCbCr422_10B = 0x14, - YCbCr422_12B = 0x12, -}; - static const u16 csc_coeff_default[3][4] = { { 0x2000, 0x0000, 0x0000, 0x0000 }, { 0x0000, 0x2000, 0x0000, 0x0000 }, @@ -856,10 +842,10 @@ static void dw_hdmi_gp_audio_enable(struct dw_hdmi *hdmi) if (pdata->enable_audio) pdata->enable_audio(hdmi, - hdmi->channels, - hdmi->sample_width, - hdmi->sample_rate, - hdmi->sample_non_pcm); + hdmi->channels, + hdmi->sample_width, + hdmi->sample_rate, + hdmi->sample_non_pcm); } static void dw_hdmi_gp_audio_disable(struct dw_hdmi *hdmi)
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-)