| Message ID | 20230420104231.2243079-3-srinivas.neeli@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog: xilinx_wwdt: Add Versal watchdog support | expand |
On 20/04/2023 12:42, Srinivas Neeli wrote: > Versal watchdog IP uses window watchdog mode. Window watchdog > timer(WWDT) contains closed(first) and open(second) window with > 32 bit width. Write to the watchdog timer within predefined window > periods of time. This means a period that is not too soon and > a period that is not too late. > > Add devicetree bindings for versal window watchdog device. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com> > --- > Changes in V4: > - Updated commit subject(removed redundant "bindings"). > - Updated commit descriptioni(removed "this patch"). > - Updated watchdog.yaml reference to local. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Apr 20, 2023 at 04:12:29PM +0530, Srinivas Neeli wrote: > Versal watchdog IP uses window watchdog mode. Window watchdog > timer(WWDT) contains closed(first) and open(second) window with > 32 bit width. Write to the watchdog timer within predefined window > periods of time. This means a period that is not too soon and > a period that is not too late. > > Add devicetree bindings for versal window watchdog device. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > Changes in V4: > - Updated commit subject(removed redundant "bindings"). > - Updated commit descriptioni(removed "this patch"). > - Updated watchdog.yaml reference to local. > Changes in V3: > - Removed xlnx,close_percent property. > Changes in V2: > - Added watchdog ref > - Removed timeout-sec property > - Used 4 spaces for example indentation. > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..14b069599740 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas <srinivas.neeli@amd.com> > + > +description: > + Versal watchdog intellectual property uses window watchdog mode. > + Window watchdog timer(WWDT) contains closed(first) and open(second) > + window with 32 bit width. Write to the watchdog timer within > + predefined window periods of time. This means a period that is not > + too soon and a period that is not too late. The WWDT has to be > + restarted within the open window time. If software tries to restart > + WWDT outside of the open window time period, it generates a reset. > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + enum: > + - xlnx,versal-wwdt > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + watchdog@fd4d0000 { > + compatible = "xlnx,versal-wwdt"; > + reg = <0xfd4d0000 0x10000>; > + clocks = <&clock25>; > + timeout-sec = <30>; > + }; > +... > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml new file mode 100644 index 000000000000..14b069599740 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx Versal window watchdog timer controller + +maintainers: + - Neeli Srinivas <srinivas.neeli@amd.com> + +description: + Versal watchdog intellectual property uses window watchdog mode. + Window watchdog timer(WWDT) contains closed(first) and open(second) + window with 32 bit width. Write to the watchdog timer within + predefined window periods of time. This means a period that is not + too soon and a period that is not too late. The WWDT has to be + restarted within the open window time. If software tries to restart + WWDT outside of the open window time period, it generates a reset. + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + enum: + - xlnx,versal-wwdt + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - clocks + +unevaluatedProperties: false + +examples: + - | + watchdog@fd4d0000 { + compatible = "xlnx,versal-wwdt"; + reg = <0xfd4d0000 0x10000>; + clocks = <&clock25>; + timeout-sec = <30>; + }; +...
Versal watchdog IP uses window watchdog mode. Window watchdog timer(WWDT) contains closed(first) and open(second) window with 32 bit width. Write to the watchdog timer within predefined window periods of time. This means a period that is not too soon and a period that is not too late. Add devicetree bindings for versal window watchdog device. Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com> --- Changes in V4: - Updated commit subject(removed redundant "bindings"). - Updated commit descriptioni(removed "this patch"). - Updated watchdog.yaml reference to local. Changes in V3: - Removed xlnx,close_percent property. Changes in V2: - Added watchdog ref - Removed timeout-sec property - Used 4 spaces for example indentation. --- .../bindings/watchdog/xlnx,versal-wwdt.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml