| Message ID | 1341784614-2797-5-git-send-email-dh.herrmann@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jul 8, 2012 at 11:56 PM, David Herrmann <dh.herrmann@googlemail.com> wrote: > --- a/drivers/video/fbmem.c > +++ b/drivers/video/fbmem.c > @@ -46,7 +46,7 @@ static DEFINE_MUTEX(registration_lock); > struct fb_info *registered_fb[FB_MAX] __read_mostly; > int num_registered_fb __read_mostly; > > -static struct fb_info *get_fb_info(unsigned int idx) > +struct fb_info *get_fb_info(unsigned int idx) > { > struct fb_info *fb_info; > > @@ -61,14 +61,16 @@ static struct fb_info *get_fb_info(unsigned int idx) > > return fb_info; > } > +EXPORT_SYMBOL(get_fb_info); EXPORT_SYMBOL_GPL? > -static void put_fb_info(struct fb_info *fb_info) > +void put_fb_info(struct fb_info *fb_info) > { > if (!atomic_dec_and_test(&fb_info->count)) > return; > if (fb_info->fbops->fb_destroy) > fb_info->fbops->fb_destroy(fb_info); > } > +EXPORT_SYMBOL(put_fb_info); EXPORT_SYMBOL_GPL? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert On Mon, Jul 9, 2012 at 9:34 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sun, Jul 8, 2012 at 11:56 PM, David Herrmann > <dh.herrmann@googlemail.com> wrote: >> --- a/drivers/video/fbmem.c >> +++ b/drivers/video/fbmem.c >> @@ -46,7 +46,7 @@ static DEFINE_MUTEX(registration_lock); >> struct fb_info *registered_fb[FB_MAX] __read_mostly; >> int num_registered_fb __read_mostly; >> >> -static struct fb_info *get_fb_info(unsigned int idx) >> +struct fb_info *get_fb_info(unsigned int idx) >> { >> struct fb_info *fb_info; >> >> @@ -61,14 +61,16 @@ static struct fb_info *get_fb_info(unsigned int idx) >> >> return fb_info; >> } >> +EXPORT_SYMBOL(get_fb_info); > > EXPORT_SYMBOL_GPL? Thanks, that seems more appropriate here. I've fixed it. >> -static void put_fb_info(struct fb_info *fb_info) >> +void put_fb_info(struct fb_info *fb_info) >> { >> if (!atomic_dec_and_test(&fb_info->count)) >> return; >> if (fb_info->fbops->fb_destroy) >> fb_info->fbops->fb_destroy(fb_info); >> } >> +EXPORT_SYMBOL(put_fb_info); > > EXPORT_SYMBOL_GPL? Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 0dff12a..474460c 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -46,7 +46,7 @@ static DEFINE_MUTEX(registration_lock); struct fb_info *registered_fb[FB_MAX] __read_mostly; int num_registered_fb __read_mostly; -static struct fb_info *get_fb_info(unsigned int idx) +struct fb_info *get_fb_info(unsigned int idx) { struct fb_info *fb_info; @@ -61,14 +61,16 @@ static struct fb_info *get_fb_info(unsigned int idx) return fb_info; } +EXPORT_SYMBOL(get_fb_info); -static void put_fb_info(struct fb_info *fb_info) +void put_fb_info(struct fb_info *fb_info) { if (!atomic_dec_and_test(&fb_info->count)) return; if (fb_info->fbops->fb_destroy) fb_info->fbops->fb_destroy(fb_info); } +EXPORT_SYMBOL(put_fb_info); int lock_fb_info(struct fb_info *info) { diff --git a/include/linux/fb.h b/include/linux/fb.h index ac3f1c6..2d51c0e 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -1033,6 +1033,9 @@ static inline void unlock_fb_info(struct fb_info *info) mutex_unlock(&info->lock); } +extern struct fb_info *get_fb_info(unsigned int idx); +extern void put_fb_info(struct fb_info *fb_info); + static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pitch, u32 height) {
When adding other internal users of the framebuffer subsystem, we need a way to get references to framebuffers. These two functions already exist so export them. Signed-off-by: David Herrmann <dh.herrmann@googlemail.com> --- drivers/video/fbmem.c | 6 ++++-- include/linux/fb.h | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-)