| Message ID | 20230531072854.142629-1-claudiu.beznea@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/stm: ltdc: check memory returned by devm_kzalloc() | expand |
On 5/31/23 09:28, Claudiu Beznea wrote: > devm_kzalloc() can fail and return NULL pointer. Check its return status. > Identified with Coccinelle (kmerr.cocci script). > > Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > > Hi, Hi Claudiu > > This has been addressed using kmerr.cocci script proposed for update > at [1]. > > Thank you, > Claudiu Beznea > > [1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@microchip.com/ > > drivers/gpu/drm/stm/ltdc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 03c6becda795..9f3ac54d4cb3 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -1579,6 +1579,8 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev, > ARRAY_SIZE(ltdc_drm_fmt_ycbcr_sp) + > ARRAY_SIZE(ltdc_drm_fmt_ycbcr_fp)) * > sizeof(*formats), GFP_KERNEL); > + if (!formats) > + return NULL; > > for (i = 0; i < ldev->caps.pix_fmt_nb; i++) { > drm_fmt = ldev->caps.pix_fmt_drm[i]; Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Thanks for your patch. Cheers, Raphaël G.-P.
On 5/31/23 09:28, Claudiu Beznea wrote: > devm_kzalloc() can fail and return NULL pointer. Check its return status. > Identified with Coccinelle (kmerr.cocci script). > > Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > > Hi, > > This has been addressed using kmerr.cocci script proposed for update > at [1]. > > Thank you, > Claudiu Beznea > > [1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@microchip.com/ > Hi Claudiu, After some delay: applied on drm-misc-next. Thank, Raphaël
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 03c6becda795..9f3ac54d4cb3 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -1579,6 +1579,8 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev, ARRAY_SIZE(ltdc_drm_fmt_ycbcr_sp) + ARRAY_SIZE(ltdc_drm_fmt_ycbcr_fp)) * sizeof(*formats), GFP_KERNEL); + if (!formats) + return NULL; for (i = 0; i < ldev->caps.pix_fmt_nb; i++) { drm_fmt = ldev->caps.pix_fmt_drm[i];
devm_kzalloc() can fail and return NULL pointer. Check its return status. Identified with Coccinelle (kmerr.cocci script). Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- Hi, This has been addressed using kmerr.cocci script proposed for update at [1]. Thank you, Claudiu Beznea [1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@microchip.com/ drivers/gpu/drm/stm/ltdc.c | 2 ++ 1 file changed, 2 insertions(+)