| Message ID | 20230531213032.25338-31-vishal.moola@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Split ptdesc from struct page | expand |
On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) <vishal.moola@gmail.com> wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Geert! On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > <vishal.moola@gmail.com> wrote: > > Part of the conversions to replace pgtable constructor/destructors with > > ptdesc equivalents. Also cleans up some spacing issues. > > > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> > > LGTM, so > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> I assume this series is supposed to go through some mm tree? Adrian
Hi Adrian, On Thu, Jun 1, 2023 at 9:28 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > > <vishal.moola@gmail.com> wrote: > > > Part of the conversions to replace pgtable constructor/destructors with > > > ptdesc equivalents. Also cleans up some spacing issues. > > > > > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> > > > > LGTM, so > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I assume this series is supposed to go through some mm tree? I think so, so your Acked-by would be appreciated... Gr{oetje,eeting}s, Geert
On Thu, 2023-06-01 at 09:42 +0200, Geert Uytterhoeven wrote: > Hi Adrian, > > On Thu, Jun 1, 2023 at 9:28 AM John Paul Adrian Glaubitz > <glaubitz@physik.fu-berlin.de> wrote: > > On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > > > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > > > <vishal.moola@gmail.com> wrote: > > > > Part of the conversions to replace pgtable constructor/destructors with > > > > ptdesc equivalents. Also cleans up some spacing issues. > > > > > > > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> > > > > > > LGTM, so > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > I assume this series is supposed to go through some mm tree? > > I think so, so your Acked-by would be appreciated... OK, I will have a look. Btw, can you have a look at the second series by Artur ("SuperH DMAC fixes")? I haven't had the time for these yet, but I will have time in the weekend. Adrian
On Thu, Jun 1, 2023 at 12:28 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > > Hi Geert! > > On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > > <vishal.moola@gmail.com> wrote: > > > Part of the conversions to replace pgtable constructor/destructors with > > > ptdesc equivalents. Also cleans up some spacing issues. > > > > > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> > > > > LGTM, so > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I assume this series is supposed to go through some mm tree? Hi Adrian, I was going to have Andrew take this through mm-unstable once it gets enough review.
On Wed, 2023-05-31 at 14:30 -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> > --- > arch/sh/include/asm/pgalloc.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h > index a9e98233c4d4..5d8577ab1591 100644 > --- a/arch/sh/include/asm/pgalloc.h > +++ b/arch/sh/include/asm/pgalloc.h > @@ -2,6 +2,7 @@ > #ifndef __ASM_SH_PGALLOC_H > #define __ASM_SH_PGALLOC_H > > +#include <linux/mm.h> > #include <asm/page.h> > > #define __HAVE_ARCH_PMD_ALLOC_ONE > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, > set_pmd(pmd, __pmd((unsigned long)page_address(pte))); > } > > -#define __pte_free_tlb(tlb,pte,addr) \ > -do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb), (pte)); \ > +#define __pte_free_tlb(tlb, pte, addr) \ > +do { \ > + pagetable_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ > } while (0) > > #endif /* __ASM_SH_PGALLOC_H */ Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index a9e98233c4d4..5d8577ab1591 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -2,6 +2,7 @@ #ifndef __ASM_SH_PGALLOC_H #define __ASM_SH_PGALLOC_H +#include <linux/mm.h> #include <asm/page.h> #define __HAVE_ARCH_PMD_ALLOC_ONE @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, set_pmd(pmd, __pmd((unsigned long)page_address(pte))); } -#define __pte_free_tlb(tlb,pte,addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif /* __ASM_SH_PGALLOC_H */
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> --- arch/sh/include/asm/pgalloc.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)