| Message ID | 20230604061421.3787649-1-alexeymin@postmarketos.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Add SDM660 compatible | expand |
On 04/06/2023 08:14, Alexey Minnekhanov wrote: > Mention sdm660-mss-pil in compatibles list. > > Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> > --- > .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml > index c1ac6ca1e759d..09da5616e1e5a 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml > @@ -19,6 +19,7 @@ properties: > enum: > - qcom,msm8996-mss-pil > - qcom,msm8998-mss-pil > + - qcom,sdm660-mss-pil > - qcom,sdm845-mss-pil > > reg: > @@ -245,7 +246,9 @@ allOf: > - if: > properties: > compatible: > - const: qcom,msm8998-mss-pil > + enum: > + - qcom,msm8998-mss-pil > + - qcom,sdm660-mss-pil You also need to restrict/constrain power domains and resets. Best regards, Krzysztof
On 04.06.2023 12:11, Krzysztof Kozlowski wrote:> > You also need to restrict/constrain power domains and resets. > > Best regards, > Krzysztof > If I understand correctly, power domains and resets should be already restricted together with msm8996+msm8998 by "else" branch [1]? Am I missing something? [1] https://elixir.bootlin.com/linux/v6.4-rc4/source/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml#L311
On 04/06/2023 15:35, Alexey Minnekhanov wrote: > On 04.06.2023 12:11, Krzysztof Kozlowski wrote:> >> You also need to restrict/constrain power domains and resets. >> >> Best regards, >> Krzysztof >> > > If I understand correctly, power domains and resets should be already > restricted together with msm8996+msm8998 by "else" branch [1]? > Am I missing something? Ah, right. Best regards, Krzysztof
On 04/06/2023 08:14, Alexey Minnekhanov wrote: > Mention sdm660-mss-pil in compatibles list. > > Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml index c1ac6ca1e759d..09da5616e1e5a 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml @@ -19,6 +19,7 @@ properties: enum: - qcom,msm8996-mss-pil - qcom,msm8998-mss-pil + - qcom,sdm660-mss-pil - qcom,sdm845-mss-pil reg: @@ -245,7 +246,9 @@ allOf: - if: properties: compatible: - const: qcom,msm8998-mss-pil + enum: + - qcom,msm8998-mss-pil + - qcom,sdm660-mss-pil then: properties: clocks:
Mention sdm660-mss-pil in compatibles list. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> --- .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)