ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG

Commit Message

Arnd Bergmann June 2, 2023, 12:44 p.m. UTC

From: Arnd Bergmann <[e-mail]>

The vangogh driver just gained a link time dependency that now causes
randconfig builds to fail:

x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function `snd_acp5x_probe':
pci-acp5x.c:(.text+0xbb): undefined reference to `snd_amd_acp_find_config'

Fixes: e89f45edb747e ("ASoC: amd: vangogh: Add check for acp config flags in vangogh platform")
Signed-off-by: Arnd Bergmann <[e-mail]>
---
 sound/soc/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann June 5, 2023, 8:58 a.m. UTC | #1

On Fri, Jun 2, 2023, at 14:44, Arnd Bergmann wrote:
> From: Arnd Bergmann <[e-mail]>
>
> The vangogh driver just gained a link time dependency that now causes
> randconfig builds to fail:
>
> x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function 
> `snd_acp5x_probe':
> pci-acp5x.c:(.text+0xbb): undefined reference to 
> `snd_amd_acp_find_config'
>
> Fixes: e89f45edb747e ("ASoC: amd: vangogh: Add check for acp config 
> flags in vangogh platform")
> Signed-off-by: Arnd Bergmann <[e-mail]>

Please disregard, this version was incomplete, and I ran into the
same issue again in another randconfig build.

v2 coming up, please use that instead.

Mark Brown June 5, 2023, 12:22 p.m. UTC | #2

On Fri, 02 Jun 2023 14:44:39 +0200, Arnd Bergmann wrote:
> The vangogh driver just gained a link time dependency that now causes
> randconfig builds to fail:
> 
> x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function `snd_acp5x_probe':
> pci-acp5x.c:(.text+0xbb): undefined reference to `snd_amd_acp_find_config'
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG
      commit: 812a05256d673b2b9c5db906775d1e6625ba4787

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Mark Brown June 5, 2023, 12:36 p.m. UTC | #3

On Mon, Jun 05, 2023 at 10:58:25AM +0200, Arnd Bergmann wrote:

> Please disregard, this version was incomplete, and I ran into the
> same issue again in another randconfig build.

> v2 coming up, please use that instead.

I already applied this one before I saw your message...

Patch

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 08e42082f5e96..e724cb3c70b74 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -81,6 +81,7 @@  config SND_SOC_AMD_VANGOGH_MACH
 	tristate "AMD Vangogh support for NAU8821 CS35L41"
 	select SND_SOC_NAU8821
 	select SND_SOC_CS35L41_SPI
+	select SND_AMD_ACP_CONFIG
 	depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
 	help
 	  This option enables machine driver for Vangogh platform