| Message ID | 20230605120934.2306548-3-mengyingkun@loongson.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] ASoC: Add support for Loongson I2S controller | expand |
On 05/06/2023 14:09, YingKun Meng wrote: > From: Yingkun Meng <mengyingkun@loongson.cn> > > The audio card uses loongson I2S controller present in 7axxx/2kxxx chips > to transfer audio data. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested. Please resend and include all necessary entries. > > Signed-off-by: Yingkun Meng <mengyingkun@loongson.cn> > --- > .../sound/loongson,ls-audio-card.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml > > diff --git a/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml > new file mode 100644 > index 000000000000..f1d6ee346bb3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/loongson-audio-card.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson generic ASoC audio sound card. What is a "generic audio card"? Does it even match hardware? Bindings are supposed to describe hardware, which is usually very specific. Also: Drop full stop. It's a title. > + > +maintainers: > + - Yingkun Meng <mengyingkun@loongson.cn> > + > +description: > + Generic ASoC audio device for loongson platform. > + > +properties: > + compatible: > + const: loongson,ls-audio-card > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + mclk-fs: > + $ref: simple-card.yaml#/definitions/mclk-fs > + > + cpu: > + description: Holds subnode which indicates cpu dai. > + type: object > + additionalProperties: false > + properties: > + sound-dai: > + maxItems: 1 In the cpu: required with sound-dai > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + additionalProperties: false > + properties: > + sound-dai: > + maxItems: 1 In the codec: required with sound-dai No multiple dai links? Are you sure this card is so limited? Best regards, Krzysztof
On Mon, Jun 05, 2023 at 04:45:38PM +0200, Krzysztof Kozlowski wrote: > On 05/06/2023 14:09, YingKun Meng wrote: > > +title: Loongson generic ASoC audio sound card. > What is a "generic audio card"? Does it even match hardware? Bindings > are supposed to describe hardware, which is usually very specific. The concept of a generic, reusable sound card seems reasonably clear - there's a bunch of in tree examples already and the idea that we have to pull together multiple bits of hardware to make a useful sound subsystem is a known thing. > Also: Drop full stop. It's a title. Shouldn't this be checked by the tooling?
Hi Krzysztof, Thanks for your kindly work. On 2023/6/5 22:45, Krzysztof Kozlowski wrote: > On 05/06/2023 14:09, YingKun Meng wrote: >> From: Yingkun Meng <mengyingkun@loongson.cn> >> >> The audio card uses loongson I2S controller present in 7axxx/2kxxx chips >> to transfer audio data. > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested. > Please resend and include all necessary entries. > Sorry for my mistake. Fixed in new version. >> Signed-off-by: Yingkun Meng <mengyingkun@loongson.cn> >> --- >> .../sound/loongson,ls-audio-card.yaml | 64 +++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml >> new file mode 100644 >> index 000000000000..f1d6ee346bb3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/loongson-audio-card.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Loongson generic ASoC audio sound card. > What is a "generic audio card"? Does it even match hardware? Bindings > are supposed to describe hardware, which is usually very specific. > > Also: Drop full stop. It's a title. > On loongson platform, the I2S controllers connect different codecs to form different audio devices that can be driven by the same machine driver. The "generic audio card" refers to these audio devices. Currently, it can match some specific hardware, such as 2k2000 + es8323: the 2k2000 is a loogson SoC with a I2S controller 7a2000 + es8288: the 7a2000 is a bridge chip with a I2S controller >> + >> +maintainers: >> + - Yingkun Meng <mengyingkun@loongson.cn> >> + >> +description: >> + Generic ASoC audio device for loongson platform. >> + >> +properties: >> + compatible: >> + const: loongson,ls-audio-card >> + >> + model: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: User specified audio sound card name >> + >> + mclk-fs: >> + $ref: simple-card.yaml#/definitions/mclk-fs >> + >> + cpu: >> + description: Holds subnode which indicates cpu dai. >> + type: object >> + additionalProperties: false >> + properties: >> + sound-dai: >> + maxItems: 1 > In the cpu: required with sound-dai OK. >> + >> + codec: >> + description: Holds subnode which indicates codec dai. >> + type: object >> + additionalProperties: false >> + properties: >> + sound-dai: >> + maxItems: 1 > In the codec: required with sound-dai > > No multiple dai links? Are you sure this card is so limited? Yes. The audio device has only one channel. > > Best regards, > Krzysztof Thanks, Yingkun Meng
On 2023/6/5 23:06, Mark Brown wrote: > On Mon, Jun 05, 2023 at 04:45:38PM +0200, Krzysztof Kozlowski wrote: >> On 05/06/2023 14:09, YingKun Meng wrote: >>> +title: Loongson generic ASoC audio sound card. >> What is a "generic audio card"? Does it even match hardware? Bindings >> are supposed to describe hardware, which is usually very specific. > The concept of a generic, reusable sound card seems reasonably clear - > there's a bunch of in tree examples already and the idea that we have to > pull together multiple bits of hardware to make a useful sound subsystem > is a known thing. > >> Also: Drop full stop. It's a title. > Shouldn't this be checked by the tooling? All work will be done in the new version. Thanks, Yingkun Meng
diff --git a/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml new file mode 100644 index 000000000000..f1d6ee346bb3 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/loongson-audio-card.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson generic ASoC audio sound card. + +maintainers: + - Yingkun Meng <mengyingkun@loongson.cn> + +description: + Generic ASoC audio device for loongson platform. + +properties: + compatible: + const: loongson,ls-audio-card + + model: + $ref: /schemas/types.yaml#/definitions/string + description: User specified audio sound card name + + mclk-fs: + $ref: simple-card.yaml#/definitions/mclk-fs + + cpu: + description: Holds subnode which indicates cpu dai. + type: object + additionalProperties: false + properties: + sound-dai: + maxItems: 1 + + codec: + description: Holds subnode which indicates codec dai. + type: object + additionalProperties: false + properties: + sound-dai: + maxItems: 1 + +required: + - compatible + - model + - mclk-fs + - cpu + - codec + +additionalProperties: false + +examples: + - | + sound { + compatible = "loongson,ls-audio-card"; + model = "loongson-audio"; + mclk-fs = <512>; + + cpu { + sound-dai = <&i2s>; + }; + codec { + sound-dai = <&es8323>; + }; + };