| Message ID | 20230601013759.75500-1-bo.wu@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fddd7d0466ae9f68582138b69b7c076e9aa97193 |
| Headers | show |
| Series | [f2fs-dev,v3,1/1] f2fs: fix args passed to trace_f2fs_lookup_end | expand |
On 2023/6/1 9:37, Wu Bo wrote: > The NULL return of 'd_splice_alias' dosen't mean error. Thus the > successful case will also return NULL, which makes the tracepoint always > print 'err=-ENOENT'. > > And the different cases of 'new' & 'err' are list as following: > 1) dentry exists: err(0) with new(NULL) --> dentry, err=0 > 2) dentry exists: err(0) with new(VALID) --> new, err=0 > 3) dentry exists: err(0) with new(ERR) --> dentry, err=ERR > 4) no dentry exists: err(-ENOENT) with new(NULL) --> dentry, err=-ENOENT > 5) no dentry exists: err(-ENOENT) with new(VALID) --> new, err=-ENOENT > 6) no dentry exists: err(-ENOENT) with new(ERR) --> dentry, err=ERR > > Signed-off-by: Wu Bo <bo.wu@vivo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Thu, 1 Jun 2023 09:37:59 +0800 you wrote: > The NULL return of 'd_splice_alias' dosen't mean error. Thus the > successful case will also return NULL, which makes the tracepoint always > print 'err=-ENOENT'. > > And the different cases of 'new' & 'err' are list as following: > 1) dentry exists: err(0) with new(NULL) --> dentry, err=0 > 2) dentry exists: err(0) with new(VALID) --> new, err=0 > 3) dentry exists: err(0) with new(ERR) --> dentry, err=ERR > 4) no dentry exists: err(-ENOENT) with new(NULL) --> dentry, err=-ENOENT > 5) no dentry exists: err(-ENOENT) with new(VALID) --> new, err=-ENOENT > 6) no dentry exists: err(-ENOENT) with new(ERR) --> dentry, err=ERR > > [...] Here is the summary with links: - [f2fs-dev,v3,1/1] f2fs: fix args passed to trace_f2fs_lookup_end https://git.kernel.org/jaegeuk/f2fs/c/fddd7d0466ae You are awesome, thank you!
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 77a71276ecb1..3e35eb7dbb8f 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -576,8 +576,8 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry, } #endif new = d_splice_alias(inode, dentry); - err = PTR_ERR_OR_ZERO(new); - trace_f2fs_lookup_end(dir, dentry, ino, !new ? -ENOENT : err); + trace_f2fs_lookup_end(dir, !IS_ERR_OR_NULL(new) ? new : dentry, + ino, IS_ERR(new) ? PTR_ERR(new) : err); return new; out_iput: iput(inode);
The NULL return of 'd_splice_alias' dosen't mean error. Thus the successful case will also return NULL, which makes the tracepoint always print 'err=-ENOENT'. And the different cases of 'new' & 'err' are list as following: 1) dentry exists: err(0) with new(NULL) --> dentry, err=0 2) dentry exists: err(0) with new(VALID) --> new, err=0 3) dentry exists: err(0) with new(ERR) --> dentry, err=ERR 4) no dentry exists: err(-ENOENT) with new(NULL) --> dentry, err=-ENOENT 5) no dentry exists: err(-ENOENT) with new(VALID) --> new, err=-ENOENT 6) no dentry exists: err(-ENOENT) with new(ERR) --> dentry, err=ERR Signed-off-by: Wu Bo <bo.wu@vivo.com> --- fs/f2fs/namei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)