mbox series

[5.10.y-cip,0/7] Add SCI support for RZ/G2L alike SoCs

Message ID 20230605110512.111017-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series Add SCI support for RZ/G2L alike SoCs | expand

Message

Biju Das June 5, 2023, 11:05 a.m. UTC
This patch series aims to add SCI support for RZ/G2L alike SoCs.
While at it, added DMA fixes for SCIF IP.

All these patches are cherry-picked from the mainline except patch#7 as
we don't have proper DT overlay support in 5.10.

Biju Das (7):
  tty: serial: sh-sci: Fix TE setting on SCI IP
  tty: serial: sh-sci: Add support for tx end interrupt handling
  tty: serial: sh-sci: Fix end of transmission on SCI
  tty: serial: sh-sci: Remove setting {src,dst}_{addr,addr_width} based
    on DMA direction
  tty: serial: sh-sci: Add RZ/G2L SCIFA DMA tx support
  tty: serial: sh-sci: Add RZ/G2L SCIFA DMA rx support
  arm64: dts: renesas: rzg2ul-smarc: Enable SCI0

 arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi |  26 ++++
 drivers/tty/serial/sh-sci.c                   | 111 ++++++++++++++----
 drivers/tty/serial/sh-sci.h                   |   3 +
 3 files changed, 117 insertions(+), 23 deletions(-)

Comments

Pavel Machek June 5, 2023, 3:27 p.m. UTC | #1
Hi!

> This patch series aims to add SCI support for RZ/G2L alike SoCs.
> While at it, added DMA fixes for SCIF IP.
> 
> All these patches are cherry-picked from the mainline except patch#7 as
> we don't have proper DT overlay support in 5.10.

This series looks okay to me, I can apply it if it passes testing and
if there are no other comments.

Best regards,
								Pavel
Nobuhiro Iwamatsu June 6, 2023, 1:30 a.m. UTC | #2
Hi all,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Monday, June 5, 2023 8:05 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○DITC□
> DIT○OST) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das
> <biju.das.jz@bp.renesas.com>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 5.10.y-cip 0/7] Add SCI support for RZ/G2L alike SoCs
> 
> This patch series aims to add SCI support for RZ/G2L alike SoCs.
> While at it, added DMA fixes for SCIF IP.
> 
> All these patches are cherry-picked from the mainline except patch#7 as we
> don't have proper DT overlay support in 5.10.
> 
> Biju Das (7):
>   tty: serial: sh-sci: Fix TE setting on SCI IP
>   tty: serial: sh-sci: Add support for tx end interrupt handling
>   tty: serial: sh-sci: Fix end of transmission on SCI
>   tty: serial: sh-sci: Remove setting {src,dst}_{addr,addr_width} based
>     on DMA direction
>   tty: serial: sh-sci: Add RZ/G2L SCIFA DMA tx support
>   tty: serial: sh-sci: Add RZ/G2L SCIFA DMA rx support
>   arm64: dts: renesas: rzg2ul-smarc: Enable SCI0
> 
>  arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi |  26 ++++
>  drivers/tty/serial/sh-sci.c                   | 111
> ++++++++++++++----
>  drivers/tty/serial/sh-sci.h                   |   3 +
>  3 files changed, 117 insertions(+), 23 deletions(-)
> 

I reviewed this series, there were no issues.
I can apply, if there are no other comments and issues.

Reviewed-by Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro
Pavel Machek June 6, 2023, 8:52 a.m. UTC | #3
Hi!

> > Biju Das (7):
> >   tty: serial: sh-sci: Fix TE setting on SCI IP
> >   tty: serial: sh-sci: Add support for tx end interrupt handling
> >   tty: serial: sh-sci: Fix end of transmission on SCI
> >   tty: serial: sh-sci: Remove setting {src,dst}_{addr,addr_width} based
> >     on DMA direction
> >   tty: serial: sh-sci: Add RZ/G2L SCIFA DMA tx support
> >   tty: serial: sh-sci: Add RZ/G2L SCIFA DMA rx support
> >   arm64: dts: renesas: rzg2ul-smarc: Enable SCI0
> > 
> >  arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi |  26 ++++
> >  drivers/tty/serial/sh-sci.c                   | 111
> > ++++++++++++++----
> >  drivers/tty/serial/sh-sci.h                   |   3 +
> >  3 files changed, 117 insertions(+), 23 deletions(-)
> > 
> 
> I reviewed this series, there were no issues.
> I can apply, if there are no other comments and issues.
> 
> Reviewed-by Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Thanks for review, I tested the series, added you reviewed-by tag
(with added :) and pushed the changes.

Best regards,
								Pavel