| Message ID | 20230606092806.1604491-1-chandan.babu@oracle.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Metadump v2 | expand |
On Tue, Jun 06, 2023 at 02:57:43PM +0530, Chandan Babu R wrote: > Hi all, > > This patch series extends metadump/mdrestore tools to be able to dump > and restore contents of an external log device. It also adds the > ability to copy larger blocks (e.g. 4096 bytes instead of 512 bytes) > into the metadump file. These objectives are accomplished by > introducing a new metadump file format. > > I have tested the patchset by extending metadump/mdrestore tests in > fstests to cover the newly introduced metadump v2 format. The tests > can be found at > https://github.com/chandanr/xfstests/commits/metadump-v2. > > The patch series can also be obtained from > https://github.com/chandanr/xfsprogs-dev/commits/metadump-v2. There is already a V2 on the list, why is this also tagged as V2?
On Tue, Jun 06, 2023 at 02:10:17 PM +0200, Carlos Maiolino wrote: > On Tue, Jun 06, 2023 at 02:57:43PM +0530, Chandan Babu R wrote: >> Hi all, >> >> This patch series extends metadump/mdrestore tools to be able to dump >> and restore contents of an external log device. It also adds the >> ability to copy larger blocks (e.g. 4096 bytes instead of 512 bytes) >> into the metadump file. These objectives are accomplished by >> introducing a new metadump file format. >> >> I have tested the patchset by extending metadump/mdrestore tests in >> fstests to cover the newly introduced metadump v2 format. The tests >> can be found at >> https://github.com/chandanr/xfstests/commits/metadump-v2. >> >> The patch series can also be obtained from >> https://github.com/chandanr/xfsprogs-dev/commits/metadump-v2. > > There is already a V2 on the list, why is this also tagged as V2? The "v2" mentioned in "Metadump v2" refers to the newer version of metadump ondisk layout to support 1. Dumping metadata from external log device and 2. Dumping larger extents (4096 bytes instead of 512 bytes).
On Tue, Jun 06, 2023 at 06:08:12PM +0530, Chandan Babu R wrote: > On Tue, Jun 06, 2023 at 02:10:17 PM +0200, Carlos Maiolino wrote: > > On Tue, Jun 06, 2023 at 02:57:43PM +0530, Chandan Babu R wrote: > >> Hi all, > >> > >> This patch series extends metadump/mdrestore tools to be able to dump > >> and restore contents of an external log device. It also adds the > >> ability to copy larger blocks (e.g. 4096 bytes instead of 512 bytes) > >> into the metadump file. These objectives are accomplished by > >> introducing a new metadump file format. > >> > >> I have tested the patchset by extending metadump/mdrestore tests in > >> fstests to cover the newly introduced metadump v2 format. The tests > >> can be found at > >> https://github.com/chandanr/xfstests/commits/metadump-v2. > >> > >> The patch series can also be obtained from > >> https://github.com/chandanr/xfsprogs-dev/commits/metadump-v2. > > > > There is already a V2 on the list, why is this also tagged as V2? > > The "v2" mentioned in "Metadump v2" refers to the newer version of metadump > ondisk layout to support Sorry the noise, I didn't get through the patches yet, just read 2 threads with the same subject (without spotting the actual V2 in the patch metadata). Thanks, my bad. :) > 1. Dumping metadata from external log device and > 2. Dumping larger extents (4096 bytes instead of 512 bytes). > > -- > chandan
Hi all, This patch series extends metadump/mdrestore tools to be able to dump and restore contents of an external log device. It also adds the ability to copy larger blocks (e.g. 4096 bytes instead of 512 bytes) into the metadump file. These objectives are accomplished by introducing a new metadump file format. I have tested the patchset by extending metadump/mdrestore tests in fstests to cover the newly introduced metadump v2 format. The tests can be found at https://github.com/chandanr/xfstests/commits/metadump-v2. The patch series can also be obtained from https://github.com/chandanr/xfsprogs-dev/commits/metadump-v2. Changelog: V1 -> V2: 1. Introduce the new incompat flag XFS_MD2_INCOMPAT_EXTERNALLOG to indicate that the metadump file contains data obtained from an external log. 2. Interpret bits 54 and 55 of xfs_meta_extent.xme_addr as a counter such that 00 maps to the data device and 01 maps to the log device. 3. Define the new function set_log_cur() to read from internal/external log device. This allows us to continue using TYP_LOG to read from both internal and external log. 4. In order to support reading metadump from a pipe, mdrestore now reads the first four bytes of the header to determine the metadump version rather than reading the entire header in a single call to fread(). 5. Add an ASCII diagram to describe metadump v2's ondisk layout in xfs_metadump.h. 6. Update metadump's man page to indicate that metadump in v2 format is generated by default if the filesystem has an external log and the metadump version to use is not explicitly mentioned on the command line. 7. Remove '_metadump' suffix from function pointer names in "struct metadump_ops". 8. Use xfs_daddr_t type for declaring variables containing disk offset value. 9. Use bool type rather than int for variables holding a boolean value. 11. Remove unnecessary whitespace. Chandan Babu R (23): metadump: Use boolean values true/false instead of 1/0 mdrestore: Fix logic used to check if target device is large enough metadump: Declare boolean variables with bool type metadump: Define and use struct metadump metadump: Add initialization and release functions metadump: Postpone invocation of init_metadump() metadump: Introduce struct metadump_ops metadump: Introduce metadump v1 operations metadump: Rename XFS_MD_MAGIC to XFS_MD_MAGIC_V1 metadump: Define metadump v2 ondisk format structures and macros metadump: Define metadump ops for v2 format xfs_db: Add support to read from external log device metadump: Add support for passing version option mdrestore: Declare boolean variables with bool type mdrestore: Define and use struct mdrestore mdrestore: Detect metadump v1 magic before reading the header mdrestore: Add open_device(), read_header() and show_info() functions mdrestore: Introduce struct mdrestore_ops mdrestore: Replace metadump header pointer argument with generic pointer type mdrestore: Introduce mdrestore v1 operations mdrestore: Extract target device size verification into a function mdrestore: Define mdrestore ops for v2 format mdrestore: Add support for passing log device as an argument db/io.c | 57 ++- db/io.h | 2 + db/metadump.c | 749 +++++++++++++++++++++++--------------- db/xfs_metadump.sh | 3 +- include/xfs_metadump.h | 60 ++- man/man8/xfs_mdrestore.8 | 8 + man/man8/xfs_metadump.8 | 14 + mdrestore/xfs_mdrestore.c | 497 +++++++++++++++++++------ 8 files changed, 985 insertions(+), 405 deletions(-)