[v2,0/4] Factorize timestamp module

Message

[e-mail] June 6, 2023, 4:21 p.m. UTC

From: Jean-Baptiste Maneyrol <[e-mail]>

The purpose if this series is to make timestamping from
inv_icm42600 driver an independent module and use it for both
inv_icm42600 and inv_mpu6050 drivers.

Create a new inv_sensors_timestamp common module based on
inv_icm42600 driver and use it in the 2 drivers.

WARNING: this patch requires following commit in fixes-togreg
bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")

Changelog
- v2: do some headers cleanup and add some justifications in
      the patches descriptions.

Jean-Baptiste Maneyrol (4):
  iio: imu: inv_icm42600: make timestamp module chip independent
  iio: move inv_icm42600 timestamp module in common
  iio: make invensense timestamp module generic
  iio: imu: inv_mpu6050: use the common inv_sensors timestamp module

 drivers/iio/common/Kconfig                    |   1 +
 drivers/iio/common/Makefile                   |   1 +
 drivers/iio/common/inv_sensors/Kconfig        |   7 ++
 drivers/iio/common/inv_sensors/Makefile       |   6 ++
 .../inv_sensors/inv_sensors_timestamp.c}      | 100 +++++++++---------
 drivers/iio/imu/inv_icm42600/Kconfig          |   1 +
 drivers/iio/imu/inv_icm42600/Makefile         |   1 -
 .../iio/imu/inv_icm42600/inv_icm42600_accel.c |  35 +++---
 .../imu/inv_icm42600/inv_icm42600_buffer.c    |  33 +++---
 .../iio/imu/inv_icm42600/inv_icm42600_core.c  |  14 ++-
 .../iio/imu/inv_icm42600/inv_icm42600_gyro.c  |  35 +++---
 .../imu/inv_icm42600/inv_icm42600_timestamp.h |  85 ---------------
 drivers/iio/imu/inv_mpu6050/Kconfig           |   1 +
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c    |  30 ++++--
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h     |  18 ++--
 drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c    |  83 ++-------------
 drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c |   6 +-
 .../linux/iio/common/inv_sensors_timestamp.h  |  95 +++++++++++++++++
 18 files changed, 278 insertions(+), 274 deletions(-)
 create mode 100644 drivers/iio/common/inv_sensors/Kconfig
 create mode 100644 drivers/iio/common/inv_sensors/Makefile
 rename drivers/iio/{imu/inv_icm42600/inv_icm42600_timestamp.c => common/inv_sensors/inv_sensors_timestamp.c} (56%)
 delete mode 100644 drivers/iio/imu/inv_icm42600/inv_icm42600_timestamp.h
 create mode 100644 include/linux/iio/common/inv_sensors_timestamp.h

Comments

Andy Shevchenko June 7, 2023, 6:26 a.m. UTC | #1

Tue, Jun 06, 2023 at 04:21:43PM +0000, [e-mail] kirjoitti:
> From: Jean-Baptiste Maneyrol <[e-mail]>
> 
> The purpose if this series is to make timestamping from
> inv_icm42600 driver an independent module and use it for both
> inv_icm42600 and inv_mpu6050 drivers.
> 
> Create a new inv_sensors_timestamp common module based on
> inv_icm42600 driver and use it in the 2 drivers.
> 
> WARNING: this patch requires following commit in fixes-togreg
> bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")

> Changelog
> - v2: do some headers cleanup and add some justifications in
>       the patches descriptions.

What I haven't noticed is my tag. It's your responsibility to add given tag and
it's polite to Cc to the reviewers (but this will imply by the tag anyway in
this case).

Any explanation why did you do so?

Jean-Baptiste Maneyrol June 7, 2023, 9:28 a.m. UTC | #2

Hello Andy,

really sorry, I forgot to do that. I'm still not very familiar with all the details of the process, sorry.

I will send a new v3 with the Reviewed-by tag. Is it OK like this?

Thanks a lot, and sorry again.
JB


From: [e-mail] <[e-mail]>
Sent: Wednesday, June 7, 2023 08:26
To: INV Git Commit <[e-mail]>
Cc: [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
Subject: Re: [PATCH v2 0/4] Factorize timestamp module 
 
[CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.

======================================================================
Tue, Jun 06, 2023 at 04:21:43PM +0000, [e-mail] kirjoitti:
> From: Jean-Baptiste Maneyrol <[e-mail]>
> 
> The purpose if this series is to make timestamping from
> inv_icm42600 driver an independent module and use it for both
> inv_icm42600 and inv_mpu6050 drivers.
> 
> Create a new inv_sensors_timestamp common module based on
> inv_icm42600 driver and use it in the 2 drivers.
> 
> WARNING: this patch requires following commit in fixes-togreg
> bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")

> Changelog
> - v2: do some headers cleanup and add some justifications in
>       the patches descriptions.

What I haven't noticed is my tag. It's your responsibility to add given tag and
it's polite to Cc to the reviewers (but this will imply by the tag anyway in
this case).

Any explanation why did you do so?

Andy Shevchenko June 7, 2023, 2:44 p.m. UTC | #3

On Wed, Jun 7, 2023 at 12:28 PM Jean-Baptiste Maneyrol
<[e-mail]> wrote:
>
> Hello Andy,
>
> really sorry, I forgot to do that. I'm still not very familiar with all the details of the process, sorry.

Understand.

> I will send a new v3 with the Reviewed-by tag. Is it OK like this?

I believe no need to resend right now as I can simply repeat it here
Reviewed-by: Andy Shevchenko <[e-mail]>
But next time be more careful.

And thank you for what you are doing!

> Thanks a lot, and sorry again.

> From: [e-mail] <[e-mail]>
> Sent: Wednesday, June 7, 2023 08:26
> To: INV Git Commit <[e-mail]>
> Cc: [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> Subject: Re: [PATCH v2 0/4] Factorize timestamp module
>
> [CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> ======================================================================
> Tue, Jun 06, 2023 at 04:21:43PM +0000, [e-mail] kirjoitti:
> > From: Jean-Baptiste Maneyrol <[e-mail]>
> >
> > The purpose if this series is to make timestamping from
> > inv_icm42600 driver an independent module and use it for both
> > inv_icm42600 and inv_mpu6050 drivers.
> >
> > Create a new inv_sensors_timestamp common module based on
> > inv_icm42600 driver and use it in the 2 drivers.
> >
> > WARNING: this patch requires following commit in fixes-togreg
> > bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")
>
> > Changelog
> > - v2: do some headers cleanup and add some justifications in
> >       the patches descriptions.
>
> What I haven't noticed is my tag. It's your responsibility to add given tag and
> it's polite to Cc to the reviewers (but this will imply by the tag anyway in
> this case).
>
> Any explanation why did you do so?
>
> --
> With Best Regards,
> Andy Shevchenko
>

Jonathan Cameron June 7, 2023, 2:58 p.m. UTC | #4

On Wed, 7 Jun 2023 09:28:12 +0000
Jean-Baptiste Maneyrol <[e-mail]> wrote:

> Hello Andy,
> 
> really sorry, I forgot to do that. I'm still not very familiar with all the details of the process, sorry.
> 
> I will send a new v3 with the Reviewed-by tag. Is it OK like this?

Go for it.   Other option is to reply with a whoops: forgot this tag and
include the tag.  That way b4 will pick it up for me when I apply.

Jonathan

> 
> Thanks a lot, and sorry again.
> JB
> 
> 
> From: [e-mail] <[e-mail]>
> Sent: Wednesday, June 7, 2023 08:26
> To: INV Git Commit <[e-mail]>
> Cc: [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> Subject: Re: [PATCH v2 0/4] Factorize timestamp module 
>  
> [CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> ======================================================================
> Tue, Jun 06, 2023 at 04:21:43PM +0000, [e-mail] kirjoitti:
> > From: Jean-Baptiste Maneyrol <[e-mail]>
> > 
> > The purpose if this series is to make timestamping from
> > inv_icm42600 driver an independent module and use it for both
> > inv_icm42600 and inv_mpu6050 drivers.
> > 
> > Create a new inv_sensors_timestamp common module based on
> > inv_icm42600 driver and use it in the 2 drivers.
> > 
> > WARNING: this patch requires following commit in fixes-togreg
> > bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")  
> 
> > Changelog
> > - v2: do some headers cleanup and add some justifications in
> >       the patches descriptions.  
> 
> What I haven't noticed is my tag. It's your responsibility to add given tag and
> it's polite to Cc to the reviewers (but this will imply by the tag anyway in
> this case).
> 
> Any explanation why did you do so?
>

Jonathan Cameron June 8, 2023, 10:57 a.m. UTC | #5

On Wed, 7 Jun 2023 17:44:39 +0300
Andy Shevchenko <[e-mail]> wrote:

> On Wed, Jun 7, 2023 at 12:28 PM Jean-Baptiste Maneyrol
> <[e-mail]> wrote:
> >
> > Hello Andy,
> >
> > really sorry, I forgot to do that. I'm still not very familiar with all the details of the process, sorry.  
> 
> Understand.
> 
> > I will send a new v3 with the Reviewed-by tag. Is it OK like this?  
> 
> I believe no need to resend right now as I can simply repeat it here
> Reviewed-by: Andy Shevchenko <[e-mail]>

That works for me ;)

Thanks Andy.

> But next time be more careful.
> 
> And thank you for what you are doing!
> 
> > Thanks a lot, and sorry again.  
> 
> > From: [e-mail] <[e-mail]>
> > Sent: Wednesday, June 7, 2023 08:26
> > To: INV Git Commit <[e-mail]>
> > Cc: [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> > Subject: Re: [PATCH v2 0/4] Factorize timestamp module
> >
> > [CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> >
> > ======================================================================
> > Tue, Jun 06, 2023 at 04:21:43PM +0000, [e-mail] kirjoitti:  
> > > From: Jean-Baptiste Maneyrol <[e-mail]>
> > >
> > > The purpose if this series is to make timestamping from
> > > inv_icm42600 driver an independent module and use it for both
> > > inv_icm42600 and inv_mpu6050 drivers.
> > >
> > > Create a new inv_sensors_timestamp common module based on
> > > inv_icm42600 driver and use it in the 2 drivers.
> > >
> > > WARNING: this patch requires following commit in fixes-togreg
> > > bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")  
> >  
> > > Changelog
> > > - v2: do some headers cleanup and add some justifications in
> > >       the patches descriptions.  
> >
> > What I haven't noticed is my tag. It's your responsibility to add given tag and
> > it's polite to Cc to the reviewers (but this will imply by the tag anyway in
> > this case).
> >
> > Any explanation why did you do so?
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >  
> 
>

Jonathan Cameron June 17, 2023, 6:51 p.m. UTC | #6

On Thu, 8 Jun 2023 11:57:40 +0100
Jonathan Cameron <[e-mail]> wrote:

> On Wed, 7 Jun 2023 17:44:39 +0300
> Andy Shevchenko <[e-mail]> wrote:
> 
> > On Wed, Jun 7, 2023 at 12:28 PM Jean-Baptiste Maneyrol
> > <[e-mail]> wrote:  
> > >
> > > Hello Andy,
> > >
> > > really sorry, I forgot to do that. I'm still not very familiar with all the details of the process, sorry.    
> > 
> > Understand.
> >   
> > > I will send a new v3 with the Reviewed-by tag. Is it OK like this?    
> > 
> > I believe no need to resend right now as I can simply repeat it here
> > Reviewed-by: Andy Shevchenko <[e-mail]>  
> 
> That works for me ;)
> 
> Thanks Andy.
Applied to the togreg branch of iio.git.  However note that these aren't
going to make the coming merge window so will only be pushed out as testing until
I can rebase on rc1.

Thanks,

Jonathan

> 
> > But next time be more careful.
> > 
> > And thank you for what you are doing!
> >   
> > > Thanks a lot, and sorry again.    
> >   
> > > From: [e-mail] <[e-mail]>
> > > Sent: Wednesday, June 7, 2023 08:26
> > > To: INV Git Commit <[e-mail]>
> > > Cc: [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> > > Subject: Re: [PATCH v2 0/4] Factorize timestamp module
> > >
> > > [CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> > >
> > > ======================================================================
> > > Tue, Jun 06, 2023 at 04:21:43PM +0000, [e-mail] kirjoitti:    
> > > > From: Jean-Baptiste Maneyrol <[e-mail]>
> > > >
> > > > The purpose if this series is to make timestamping from
> > > > inv_icm42600 driver an independent module and use it for both
> > > > inv_icm42600 and inv_mpu6050 drivers.
> > > >
> > > > Create a new inv_sensors_timestamp common module based on
> > > > inv_icm42600 driver and use it in the 2 drivers.
> > > >
> > > > WARNING: this patch requires following commit in fixes-togreg
> > > > bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset")    
> > >    
> > > > Changelog
> > > > - v2: do some headers cleanup and add some justifications in
> > > >       the patches descriptions.    
> > >
> > > What I haven't noticed is my tag. It's your responsibility to add given tag and
> > > it's polite to Cc to the reviewers (but this will imply by the tag anyway in
> > > this case).
> > >
> > > Any explanation why did you do so?
> > >
> > > --
> > > With Best Regards,
> > > Andy Shevchenko
> > >    
> > 
> >   
>