| Message ID | 3236bc555c76dcd561d38a3aea6e8489e917bc15.1686124161.git.mprivozn@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | configure: check for $download value properly | expand |
On 7/6/23 09:50, Michal Privoznik wrote: > If configure was invoked with --disable-download and git > submodules were not checked out a warning is produced and the > configure script fails. But the $download variable (which > reflects the enable/disable download argument) is checked for in > a weird fashion: > > test -f "$download" = disabled > > Drop the '-f' to check for the actual value of the variable. > > Fixes: 2019cabfee0 > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Queued, thanks. Paolo
diff --git a/configure b/configure index 8765b88e12..8a638dd82a 100755 --- a/configure +++ b/configure @@ -767,7 +767,7 @@ if test "$plugins" = "yes" -a "$tcg" = "disabled"; then fi if ! test -f "$source_path/subprojects/keycodemapdb/README" \ - && test -f "$download" = disabled + && test "$download" = disabled then echo echo "ERROR: missing subprojects"
If configure was invoked with --disable-download and git submodules were not checked out a warning is produced and the configure script fails. But the $download variable (which reflects the enable/disable download argument) is checked for in a weird fashion: test -f "$download" = disabled Drop the '-f' to check for the actual value of the variable. Fixes: 2019cabfee0 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)