| Message ID | 20230602173328.1917385-1-eperezma@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices | expand |
On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez <eperezma@redhat.com> wrote: > > QEMU does not emulate it so it must be disabled as long as the backend > does not support it. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Thanks > --- > net/vhost-vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 5360924ba0..427a57dd6f 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = { > VIRTIO_F_VERSION_1, > VIRTIO_NET_F_CSUM, > VIRTIO_NET_F_GUEST_CSUM, > + VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, > VIRTIO_NET_F_GSO, > VIRTIO_NET_F_GUEST_TSO4, > VIRTIO_NET_F_GUEST_TSO6, > -- > 2.31.1 >
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang <leiyang@redhat.com> On Tue, Jun 6, 2023 at 9:33 AM Jason Wang <jasowang@redhat.com> wrote: > > On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez <eperezma@redhat.com> wrote: > > > > QEMU does not emulate it so it must be disabled as long as the backend > > does not support it. > > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > > Acked-by: Jason Wang <jasowang@redhat.com> > > Thanks > > > --- > > net/vhost-vdpa.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > > index 5360924ba0..427a57dd6f 100644 > > --- a/net/vhost-vdpa.c > > +++ b/net/vhost-vdpa.c > > @@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = { > > VIRTIO_F_VERSION_1, > > VIRTIO_NET_F_CSUM, > > VIRTIO_NET_F_GUEST_CSUM, > > + VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, > > VIRTIO_NET_F_GSO, > > VIRTIO_NET_F_GUEST_TSO4, > > VIRTIO_NET_F_GUEST_TSO6, > > -- > > 2.31.1 > > >
02.06.2023 20:33, Eugenio Pérez wrote: > QEMU does not emulate it so it must be disabled as long as the backend > does not support it. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > --- > net/vhost-vdpa.c | 1 + > 1 file changed, 1 insertion(+) Is it -stable material? Thanks, /mjt
On Wed, Jun 7, 2023 at 12:08 PM Michael Tokarev <mjt@tls.msk.ru> wrote: > > 02.06.2023 20:33, Eugenio Pérez wrote: > > QEMU does not emulate it so it must be disabled as long as the backend > > does not support it. > > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > > --- > > net/vhost-vdpa.c | 1 + > > 1 file changed, 1 insertion(+) > > Is it -stable material? > Yes, I forgot to CC qemu-stable here too. Thanks!
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 5360924ba0..427a57dd6f 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = { VIRTIO_F_VERSION_1, VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, + VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, VIRTIO_NET_F_GSO, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6,
QEMU does not emulate it so it must be disabled as long as the backend does not support it. Signed-off-by: Eugenio Pérez <eperezma@redhat.com> --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+)