| Message ID | 20230607205714.510012-5-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable decoder for mt8183 | expand |
Il 07/06/23 22:53, Nícolas F. R. A. Prado ha scritto: > Add the CLK_VDEC_ACTIVE clock to the vdec clock driver. This clock is > enabled by the VPU once it starts decoding. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Thu, Jun 8, 2023 at 4:57 AM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > Add the CLK_VDEC_ACTIVE clock to the vdec clock driver. This clock is > enabled by the VPU once it starts decoding. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > Changes in v2: > - Added CLK_IGNORE_UNUSED flag > > drivers/clk/mediatek/clk-mt8183-vdec.c | 5 +++++ > include/dt-bindings/clock/mt8183-clk.h | 3 ++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mediatek/clk-mt8183-vdec.c b/drivers/clk/mediatek/clk-mt8183-vdec.c > index 513b7956cbea..03c4f1acfdb8 100644 > --- a/drivers/clk/mediatek/clk-mt8183-vdec.c > +++ b/drivers/clk/mediatek/clk-mt8183-vdec.c > @@ -27,6 +27,10 @@ static const struct mtk_gate_regs vdec1_cg_regs = { > GATE_MTK(_id, _name, _parent, &vdec0_cg_regs, _shift, \ > &mtk_clk_gate_ops_setclr_inv) > > +#define GATE_VDEC0(_id, _name, _parent, _shift) \ > + GATE_MTK_FLAGS(_id, _name, _parent, &vdec0_cg_regs, _shift, \ > + &mtk_clk_gate_ops_setclr, CLK_IGNORE_UNUSED) I think what you want is a read-only gate clock only used for reading back the status. The ops would only have .is_enabled. ChenYu
Il 08/06/23 09:43, Chen-Yu Tsai ha scritto: > On Thu, Jun 8, 2023 at 4:57 AM Nícolas F. R. A. Prado > <nfraprado@collabora.com> wrote: >> >> Add the CLK_VDEC_ACTIVE clock to the vdec clock driver. This clock is >> enabled by the VPU once it starts decoding. >> >> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >> >> --- >> >> Changes in v2: >> - Added CLK_IGNORE_UNUSED flag >> >> drivers/clk/mediatek/clk-mt8183-vdec.c | 5 +++++ >> include/dt-bindings/clock/mt8183-clk.h | 3 ++- >> 2 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/clk/mediatek/clk-mt8183-vdec.c b/drivers/clk/mediatek/clk-mt8183-vdec.c >> index 513b7956cbea..03c4f1acfdb8 100644 >> --- a/drivers/clk/mediatek/clk-mt8183-vdec.c >> +++ b/drivers/clk/mediatek/clk-mt8183-vdec.c >> @@ -27,6 +27,10 @@ static const struct mtk_gate_regs vdec1_cg_regs = { >> GATE_MTK(_id, _name, _parent, &vdec0_cg_regs, _shift, \ >> &mtk_clk_gate_ops_setclr_inv) >> >> +#define GATE_VDEC0(_id, _name, _parent, _shift) \ >> + GATE_MTK_FLAGS(_id, _name, _parent, &vdec0_cg_regs, _shift, \ >> + &mtk_clk_gate_ops_setclr, CLK_IGNORE_UNUSED) > > I think what you want is a read-only gate clock only used for reading back > the status. The ops would only have .is_enabled. Technically, you're right... but I would delay the introduction of a RO GATE_MTK clock for later, as it's not worth adding that for just one clock driver usage. We're checking if the same can be applied to other SoCs as well - if it can, then it would make sense to do that (small, yes), work... the point here is to enable MT8183 decoders ASAP to enable decoder tests in KernelCI, along with all of the other MediaTek Chromebooks. Though, if you think that it is a good idea to add a RO gate right now, I don't have any strong opinions against that. Cheers, Angelo
diff --git a/drivers/clk/mediatek/clk-mt8183-vdec.c b/drivers/clk/mediatek/clk-mt8183-vdec.c index 513b7956cbea..03c4f1acfdb8 100644 --- a/drivers/clk/mediatek/clk-mt8183-vdec.c +++ b/drivers/clk/mediatek/clk-mt8183-vdec.c @@ -27,6 +27,10 @@ static const struct mtk_gate_regs vdec1_cg_regs = { GATE_MTK(_id, _name, _parent, &vdec0_cg_regs, _shift, \ &mtk_clk_gate_ops_setclr_inv) +#define GATE_VDEC0(_id, _name, _parent, _shift) \ + GATE_MTK_FLAGS(_id, _name, _parent, &vdec0_cg_regs, _shift, \ + &mtk_clk_gate_ops_setclr, CLK_IGNORE_UNUSED) + #define GATE_VDEC1_I(_id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, &vdec1_cg_regs, _shift, \ &mtk_clk_gate_ops_setclr_inv) @@ -34,6 +38,7 @@ static const struct mtk_gate_regs vdec1_cg_regs = { static const struct mtk_gate vdec_clks[] = { /* VDEC0 */ GATE_VDEC0_I(CLK_VDEC_VDEC, "vdec_vdec", "mm_sel", 0), + GATE_VDEC0(CLK_VDEC_ACTIVE, "vdec_active", "mm_sel", 4), /* VDEC1 */ GATE_VDEC1_I(CLK_VDEC_LARB1, "vdec_larb1", "mm_sel", 0), }; diff --git a/include/dt-bindings/clock/mt8183-clk.h b/include/dt-bindings/clock/mt8183-clk.h index a7b470b0ec8a..32dd7d91dbe2 100644 --- a/include/dt-bindings/clock/mt8183-clk.h +++ b/include/dt-bindings/clock/mt8183-clk.h @@ -357,7 +357,8 @@ /* VDEC_GCON */ #define CLK_VDEC_VDEC 0 #define CLK_VDEC_LARB1 1 -#define CLK_VDEC_NR_CLK 2 +#define CLK_VDEC_ACTIVE 2 +#define CLK_VDEC_NR_CLK 3 /* VENC_GCON */ #define CLK_VENC_LARB 0
Add the CLK_VDEC_ACTIVE clock to the vdec clock driver. This clock is enabled by the VPU once it starts decoding. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Changes in v2: - Added CLK_IGNORE_UNUSED flag drivers/clk/mediatek/clk-mt8183-vdec.c | 5 +++++ include/dt-bindings/clock/mt8183-clk.h | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-)