mbox series

[PATCHSET,0/3] fstests: reduce scrub time in testing

Message ID 168609056295.2592490.1272515528324889317.stgit@frogsfrogsfrogs (mailing list archive)
Headers show
Series fstests: reduce scrub time in testing | expand

Message

Darrick J. Wong June 6, 2023, 10:29 p.m. UTC
Hi all,

For fuzz testing of the filesystem repair tools, there's no point in
having _check_xfs_filesystem rebuild the filesystem metadata with
xfs_repair or xfs_scrub after it's already been testing both.  This can
reduce the runtime of those tests considerably.

Do the same for xfs/503 since we're only concerned with testing that
metadump and mdrestore work properly.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=scrub-test-speedups
---
 common/fuzzy  |    7 ++++++-
 common/rc     |    2 +-
 common/xfs    |   31 ++++++++++++++++++++++---------
 tests/xfs/503 |    2 ++
 4 files changed, 31 insertions(+), 11 deletions(-)

Comments

Andrey Albershteyn June 8, 2023, 10:38 a.m. UTC | #1
On 2023-06-06 15:29:22, Darrick J. Wong wrote:
> Hi all,
> 
> For fuzz testing of the filesystem repair tools, there's no point in
> having _check_xfs_filesystem rebuild the filesystem metadata with
> xfs_repair or xfs_scrub after it's already been testing both.  This can
> reduce the runtime of those tests considerably.
> 
> Do the same for xfs/503 since we're only concerned with testing that
> metadump and mdrestore work properly.
> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=scrub-test-speedups
> ---
>  common/fuzzy  |    7 ++++++-
>  common/rc     |    2 +-
>  common/xfs    |   31 ++++++++++++++++++++++---------
>  tests/xfs/503 |    2 ++
>  4 files changed, 31 insertions(+), 11 deletions(-)
> 

The whole patchset looks good to me.
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>