mbox series

[0/2] arm*/dts: Enable symbols for rpi device trees

Message ID 20230530175624.2360218-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series arm*/dts: Enable symbols for rpi device trees | expand

Message

Uwe Kleine-König May 30, 2023, 5:56 p.m. UTC
Hello,

based on an earlier submission by Aurelien Jarno, I rebased and slightly
simplified the patches.

There was some related irc conversion in #armlinux. Quoting the relevant
parts:

1685078851< ukleinek> arnd, [florian]: Who would pick up https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net ?
1685078920< ukleinek> arnd, [florian]: If there is an agreement in general that this is a good idea, I can coordinate with Aurelien that for arm64 there is a v2 with the simpler approach I pointed out.
1685083481< arnd> ukleinek: I have no objections to this, if [florian] wants to pick it up and send me for 6.5.
1685083809< arnd> robher: any comments on this one?
1685466520 < [florian]> ukleinek: I was hoping we would get an Ack for robher before picking it up in the brcm soc tree, don't want to ruffle any feathers unnecessarily

So it seems to start a beneficial chain reaction, only Rob's Ack is
needed.

As these two changes would greatly simplify the application of dtbos for
rpi hats, I look forward to Rob agreeing to them.

Best regards
Uwe

Aurelien Jarno (2):
  arm64: dts: broadcom: Enable device-tree overlay support for RPi
    devices
  arm: dts: Enable device-tree overlay support for RPi devices

 arch/arm/boot/dts/Makefile            | 18 ++++++++++++++++++
 arch/arm64/boot/dts/broadcom/Makefile |  4 ++++
 2 files changed, 22 insertions(+)

base-commit: ac9a78681b921877518763ba0e89202254349d1b

Comments

Uwe Kleine-König June 1, 2023, 2:02 p.m. UTC | #1
Hello,

On Tue, May 30, 2023 at 07:56:22PM +0200, Uwe Kleine-König wrote:
> based on an earlier submission by Aurelien Jarno, I rebased and slightly
> simplified the patches.
> 
> There was some related irc conversion in #armlinux. Quoting the relevant
> parts:
> 
> 1685078851< ukleinek> arnd, [florian]: Who would pick up https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net ?
> 1685078920< ukleinek> arnd, [florian]: If there is an agreement in general that this is a good idea, I can coordinate with Aurelien that for arm64 there is a v2 with the simpler approach I pointed out.
> 1685083481< arnd> ukleinek: I have no objections to this, if [florian] wants to pick it up and send me for 6.5.
> 1685083809< arnd> robher: any comments on this one?
> 1685466520 < [florian]> ukleinek: I was hoping we would get an Ack for robher before picking it up in the brcm soc tree, don't want to ruffle any feathers unnecessarily
> 
> So it seems to start a beneficial chain reaction, only Rob's Ack is
> needed.

Not sure this might help, but as Rob seems to be away for mail, I'll
try: arch/arm64/boot/dts/nvidia/Makefile and
arch/arm64/boot/dts/ti/Makefile also make use of -@. So this patch at
least isn't a completely new thing and maybe Florian might dare to take
this patch even without Rob's explicit consent?!

Best regards
Uwe
Conor Dooley June 1, 2023, 2:13 p.m. UTC | #2
On Thu, Jun 01, 2023 at 04:02:14PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, May 30, 2023 at 07:56:22PM +0200, Uwe Kleine-König wrote:
> > based on an earlier submission by Aurelien Jarno, I rebased and slightly
> > simplified the patches.
> > 
> > There was some related irc conversion in #armlinux. Quoting the relevant
> > parts:
> > 
> > 1685078851< ukleinek> arnd, [florian]: Who would pick up https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net ?
> > 1685078920< ukleinek> arnd, [florian]: If there is an agreement in general that this is a good idea, I can coordinate with Aurelien that for arm64 there is a v2 with the simpler approach I pointed out.
> > 1685083481< arnd> ukleinek: I have no objections to this, if [florian] wants to pick it up and send me for 6.5.
> > 1685083809< arnd> robher: any comments on this one?
> > 1685466520 < [florian]> ukleinek: I was hoping we would get an Ack for robher before picking it up in the brcm soc tree, don't want to ruffle any feathers unnecessarily
> > 
> > So it seems to start a beneficial chain reaction, only Rob's Ack is
> > needed.
> 
> Not sure this might help, but as Rob seems to be away for mail, I'll
> try: arch/arm64/boot/dts/nvidia/Makefile and
> arch/arm64/boot/dts/ti/Makefile also make use of -@. So this patch at
> least isn't a completely new thing and maybe Florian might dare to take
> this patch even without Rob's explicit consent?!

FWIW you can have mine, unless it is explicitly Rob's you want Florian.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Florian Fainelli June 1, 2023, 3:37 p.m. UTC | #3
On 6/1/2023 7:13 AM, Conor Dooley wrote:
> On Thu, Jun 01, 2023 at 04:02:14PM +0200, Uwe Kleine-König wrote:
>> Hello,
>>
>> On Tue, May 30, 2023 at 07:56:22PM +0200, Uwe Kleine-König wrote:
>>> based on an earlier submission by Aurelien Jarno, I rebased and slightly
>>> simplified the patches.
>>>
>>> There was some related irc conversion in #armlinux. Quoting the relevant
>>> parts:
>>>
>>> 1685078851< ukleinek> arnd, [florian]: Who would pick up https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net ?
>>> 1685078920< ukleinek> arnd, [florian]: If there is an agreement in general that this is a good idea, I can coordinate with Aurelien that for arm64 there is a v2 with the simpler approach I pointed out.
>>> 1685083481< arnd> ukleinek: I have no objections to this, if [florian] wants to pick it up and send me for 6.5.
>>> 1685083809< arnd> robher: any comments on this one?
>>> 1685466520 < [florian]> ukleinek: I was hoping we would get an Ack for robher before picking it up in the brcm soc tree, don't want to ruffle any feathers unnecessarily
>>>
>>> So it seems to start a beneficial chain reaction, only Rob's Ack is
>>> needed.
>>
>> Not sure this might help, but as Rob seems to be away for mail, I'll
>> try: arch/arm64/boot/dts/nvidia/Makefile and
>> arch/arm64/boot/dts/ti/Makefile also make use of -@. So this patch at
>> least isn't a completely new thing and maybe Florian might dare to take
>> this patch even without Rob's explicit consent?!
> 
> FWIW you can have mine, unless it is explicitly Rob's you want Florian.
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

OK, I will take yours and queue those up!
Florian Fainelli June 1, 2023, 5:40 p.m. UTC | #4
On 6/1/23 08:37, Florian Fainelli wrote:
> 
> 
> On 6/1/2023 7:13 AM, Conor Dooley wrote:
>> On Thu, Jun 01, 2023 at 04:02:14PM +0200, Uwe Kleine-König wrote:
>>> Hello,
>>>
>>> On Tue, May 30, 2023 at 07:56:22PM +0200, Uwe Kleine-König wrote:
>>>> based on an earlier submission by Aurelien Jarno, I rebased and 
>>>> slightly
>>>> simplified the patches.
>>>>
>>>> There was some related irc conversion in #armlinux. Quoting the 
>>>> relevant
>>>> parts:
>>>>
>>>> 1685078851< ukleinek> arnd, [florian]: Who would pick up 
>>>> https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net ?
>>>> 1685078920< ukleinek> arnd, [florian]: If there is an agreement in 
>>>> general that this is a good idea, I can coordinate with Aurelien 
>>>> that for arm64 there is a v2 with the simpler approach I pointed out.
>>>> 1685083481< arnd> ukleinek: I have no objections to this, if 
>>>> [florian] wants to pick it up and send me for 6.5.
>>>> 1685083809< arnd> robher: any comments on this one?
>>>> 1685466520 < [florian]> ukleinek: I was hoping we would get an Ack 
>>>> for robher before picking it up in the brcm soc tree, don't want to 
>>>> ruffle any feathers unnecessarily
>>>>
>>>> So it seems to start a beneficial chain reaction, only Rob's Ack is
>>>> needed.
>>>
>>> Not sure this might help, but as Rob seems to be away for mail, I'll
>>> try: arch/arm64/boot/dts/nvidia/Makefile and
>>> arch/arm64/boot/dts/ti/Makefile also make use of -@. So this patch at
>>> least isn't a completely new thing and maybe Florian might dare to take
>>> this patch even without Rob's explicit consent?!
>>
>> FWIW you can have mine, unless it is explicitly Rob's you want Florian.
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> OK, I will take yours and queue those up!

Applied both with Conor's ack. Uwe, please copy 
bcm-kernel-feedback-list@broadcom.com next time, so the patches show up 
in our patchwork and make my life a tad easier ;)

Thanks everyone.
Uwe Kleine-König June 1, 2023, 8:55 p.m. UTC | #5
Hello Florian,

On Thu, Jun 01, 2023 at 10:40:07AM -0700, Florian Fainelli wrote:
> On 6/1/23 08:37, Florian Fainelli wrote:
> > On 6/1/2023 7:13 AM, Conor Dooley wrote:
> > > On Thu, Jun 01, 2023 at 04:02:14PM +0200, Uwe Kleine-König wrote:
> > > > On Tue, May 30, 2023 at 07:56:22PM +0200, Uwe Kleine-König wrote:
> > > > > based on an earlier submission by Aurelien Jarno, I rebased
> > > > > and slightly
> > > > > simplified the patches.
> > > > > 
> > > > > There was some related irc conversion in #armlinux. Quoting
> > > > > the relevant
> > > > > parts:
> > > > > 
> > > > > 1685078851< ukleinek> arnd, [florian]: Who would pick up https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net
> > > > > ?
> > > > > 1685078920< ukleinek> arnd, [florian]: If there is an
> > > > > agreement in general that this is a good idea, I can
> > > > > coordinate with Aurelien that for arm64 there is a v2 with
> > > > > the simpler approach I pointed out.
> > > > > 1685083481< arnd> ukleinek: I have no objections to this, if
> > > > > [florian] wants to pick it up and send me for 6.5.
> > > > > 1685083809< arnd> robher: any comments on this one?
> > > > > 1685466520 < [florian]> ukleinek: I was hoping we would get
> > > > > an Ack for robher before picking it up in the brcm soc tree,
> > > > > don't want to ruffle any feathers unnecessarily
> > > > > 
> > > > > So it seems to start a beneficial chain reaction, only Rob's Ack is
> > > > > needed.
> > > > 
> > > > Not sure this might help, but as Rob seems to be away for mail, I'll
> > > > try: arch/arm64/boot/dts/nvidia/Makefile and
> > > > arch/arm64/boot/dts/ti/Makefile also make use of -@. So this patch at
> > > > least isn't a completely new thing and maybe Florian might dare to take
> > > > this patch even without Rob's explicit consent?!
> > > 
> > > FWIW you can have mine, unless it is explicitly Rob's you want Florian.
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > OK, I will take yours and queue those up!
> 
> Applied both with Conor's ack.

Thanks to all people involved here. I'm really glad this is accepted
now, it will make using dtbos in Debian quite a bit simpler.

> Uwe, please copy
> bcm-kernel-feedback-list@broadcom.com next time, so the patches show up in
> our patchwork and make my life a tad easier ;)

You could be relatively sure I will do that, if the MAINTAINERS file
gets modified such that

	scripts/get_maintainer.pl -f arch/arm64/boot/dts/broadcom/Makefile

includes this address. I took a quick look, but it wasn't obvious to me
which entry should be expanded accordingly. (But I'll try to remember
anyhow.)

Best regards
Uwe
Cristian Birsan June 8, 2023, 2:07 p.m. UTC | #6
Hi Uwe, All,

On 5/30/23 20:56, Uwe Kleine-König wrote:
> Hello,
> 
> based on an earlier submission by Aurelien Jarno, I rebased and slightly
> simplified the patches.
> 
> There was some related irc conversion in #armlinux. Quoting the relevant
> parts:
> 
> 1685078851< ukleinek> arnd, [florian]: Who would pick up https://lore.kernel.org/linux-arm-kernel/20220410225940.135744-1-aurelien@aurel32.net ?
> 1685078920< ukleinek> arnd, [florian]: If there is an agreement in general that this is a good idea, I can coordinate with Aurelien that for arm64 there is a v2 with the simpler approach I pointed out.
> 1685083481< arnd> ukleinek: I have no objections to this, if [florian] wants to pick it up and send me for 6.5.
> 1685083809< arnd> robher: any comments on this one?
> 1685466520 < [florian]> ukleinek: I was hoping we would get an Ack for robher before picking it up in the brcm soc tree, don't want to ruffle any feathers unnecessarily
> 
> So it seems to start a beneficial chain reaction, only Rob's Ack is
> needed.
> 
> As these two changes would greatly simplify the application of dtbos for
> rpi hats, I look forward to Rob agreeing to them.

I'm interested in enabling this feature too. We used device tree overlays for Microchip AT91 boards for some time.

I can prepare a similar patch to enable them upstream.

> 
> Best regards
> Uwe

Regards,
Cristi


> 
> Aurelien Jarno (2):
>    arm64: dts: broadcom: Enable device-tree overlay support for RPi
>      devices
>    arm: dts: Enable device-tree overlay support for RPi devices
> 
>   arch/arm/boot/dts/Makefile            | 18 ++++++++++++++++++
>   arch/arm64/boot/dts/broadcom/Makefile |  4 ++++
>   2 files changed, 22 insertions(+)
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b