diff mbox series

memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check

Message ID 20230610034114.981861-1-linmiaohe@huawei.com (mailing list archive)
State New
Headers show
Series memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check | expand

Commit Message

Miaohe Lin June 10, 2023, 3:41 a.m. UTC 
establish_demotion_targets() is defined while CONFIG_MIGRATION is
enabled. There's no need to check it again.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memory-tiers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Hildenbrand June 12, 2023, 9:15 a.m. UTC | #1 
On 10.06.23 05:41, Miaohe Lin wrote:
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/memory-tiers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>   
>   	lockdep_assert_held_once(&memory_tier_lock);
>   
> -	if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> +	if (!node_demotion)
>   		return;
>   
>   	disable_all_demotion_targets();

Reviewed-by: David Hildenbrand <david@redhat.com>
Yang Shi June 12, 2023, 9:57 p.m. UTC | #2 
On Fri, Jun 9, 2023 at 8:41 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Yang Shi <shy828301@gmail.com>

> ---
>  mm/memory-tiers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>
>         lockdep_assert_held_once(&memory_tier_lock);
>
> -       if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> +       if (!node_demotion)
>                 return;
>
>         disable_all_demotion_targets();
> --
> 2.27.0
>
>
diff mbox series

Patch

diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index dd04f0ce5277..a516e303e304 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -366,7 +366,7 @@  static void establish_demotion_targets(void)
 
 	lockdep_assert_held_once(&memory_tier_lock);
 
-	if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
+	if (!node_demotion)
 		return;
 
 	disable_all_demotion_targets();