diff mbox series

[v2,1/3] wifi: mac80211: Fix tkip encrypted packet transmission path

Message ID 20230608070754.7161-2-quic_aarasahu@quicinc.com (mailing list archive)
State Changes Requested
Delegated to: Johannes Berg
Headers show
Series Enable TKIP when using encapsulation offloading | expand

Commit Message

Aaradhana Sahu June 8, 2023, 7:07 a.m. UTC 
From: Sathishkumar Muruganandam <quic_murugana@quicinc.com>

Currently, TKIP encrypted packets are transmitting through fast path
and fast_tx, fast_rx is not assigned in case of TKIP cipher so
packet is dropped during ping.

Fix this issue by sending TKIP encrypted packets through normal path

Signed-off-by: Sathishkumar Muruganandam <quic_murugana@quicinc.com>
Signed-off-by: Aaradhana Sahu <quic_aarasahu@quicinc.com>
---
 net/mac80211/tx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Johannes Berg June 14, 2023, 8:36 a.m. UTC | #1 
On Thu, 2023-06-08 at 12:37 +0530, Aaradhana Sahu wrote:
> From: Sathishkumar Muruganandam <quic_murugana@quicinc.com>
> 
> Currently, TKIP encrypted packets are transmitting through fast path
> and fast_tx, fast_rx is not assigned in case of TKIP cipher so
> packet is dropped during ping.
> 
> Fix this issue by sending TKIP encrypted packets through normal path

Not sure I understand this. How is fast_rx related, we're talking about
the TX path?

Also, how is this even a correct patch, since you submitted a series of
three patches, and
 (a) it's probably broken for ath11k until all three patches are in
     place
 (b) what about other drivers

johannes
diff mbox series

Patch

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index dfe6b9c9b29e..2d9af96783f1 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -4681,8 +4681,7 @@  netdev_tx_t ieee80211_subif_start_xmit_8023(struct sk_buff *skb,
 	if (!key)
 		key = rcu_dereference(sdata->default_unicast_key);
 
-	if (key && (!(key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) ||
-		    key->conf.cipher == WLAN_CIPHER_SUITE_TKIP))
+	if (key && (!(key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)))
 		goto skip_offload;
 
 	sk_pacing_shift_update(skb->sk, sdata->local->hw.tx_sk_pacing_shift);