mbox series

[iwl-next,0/2] iavf: make some functions static

Message ID 20230613141253.57811-1-przemyslaw.kitszel@intel.com (mailing list archive)
Headers show
Series iavf: make some functions static | expand

Message

Przemek Kitszel June 13, 2023, 2:12 p.m. UTC 
Make static functions that are used in just one translation unit.
Remove all unused and unexported functions.

Przemek Kitszel (2):
  iavf: remove some unused functions and pointless wrappers
  iavf: make functions static where possible

 drivers/net/ethernet/intel/iavf/iavf.h        | 10 -----
 drivers/net/ethernet/intel/iavf/iavf_alloc.h  |  3 +-
 drivers/net/ethernet/intel/iavf/iavf_common.c | 45 -------------------
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 34 ++++++--------
 drivers/net/ethernet/intel/iavf/iavf_osdep.h  |  9 ----
 .../net/ethernet/intel/iavf/iavf_prototype.h  |  5 ---
 drivers/net/ethernet/intel/iavf/iavf_txrx.c   | 43 +++++++++---------
 drivers/net/ethernet/intel/iavf/iavf_txrx.h   |  4 --
 8 files changed, 35 insertions(+), 118 deletions(-)

Comments

Tony Nguyen June 14, 2023, 5:27 p.m. UTC | #1 
On 6/13/2023 7:12 AM, Przemek Kitszel wrote:
> Make static functions that are used in just one translation unit.
> Remove all unused and unexported functions.

This doesn't apply.

> Przemek Kitszel (2):
>    iavf: remove some unused functions and pointless wrappers
>    iavf: make functions static where possible
> 
>   drivers/net/ethernet/intel/iavf/iavf.h        | 10 -----
>   drivers/net/ethernet/intel/iavf/iavf_alloc.h  |  3 +-
>   drivers/net/ethernet/intel/iavf/iavf_common.c | 45 -------------------
>   drivers/net/ethernet/intel/iavf/iavf_main.c   | 34 ++++++--------
>   drivers/net/ethernet/intel/iavf/iavf_osdep.h  |  9 ----
>   .../net/ethernet/intel/iavf/iavf_prototype.h  |  5 ---
>   drivers/net/ethernet/intel/iavf/iavf_txrx.c   | 43 +++++++++---------
>   drivers/net/ethernet/intel/iavf/iavf_txrx.h   |  4 --
>   8 files changed, 35 insertions(+), 118 deletions(-)
>
Przemek Kitszel June 15, 2023, 9:53 a.m. UTC | #2 
On 6/14/23 19:27, Tony Nguyen wrote:
> On 6/13/2023 7:12 AM, Przemek Kitszel wrote:
>> Make static functions that are used in just one translation unit.
>> Remove all unused and unexported functions.
> 
> This doesn't apply.

Indeed it does not, I will repost mentioning prereq commits form yours 
dev-queue


> 
>> Przemek Kitszel (2):
>>    iavf: remove some unused functions and pointless wrappers
>>    iavf: make functions static where possible
>>
>>   drivers/net/ethernet/intel/iavf/iavf.h        | 10 -----
>>   drivers/net/ethernet/intel/iavf/iavf_alloc.h  |  3 +-
>>   drivers/net/ethernet/intel/iavf/iavf_common.c | 45 -------------------
>>   drivers/net/ethernet/intel/iavf/iavf_main.c   | 34 ++++++--------
>>   drivers/net/ethernet/intel/iavf/iavf_osdep.h  |  9 ----
>>   .../net/ethernet/intel/iavf/iavf_prototype.h  |  5 ---
>>   drivers/net/ethernet/intel/iavf/iavf_txrx.c   | 43 +++++++++---------
>>   drivers/net/ethernet/intel/iavf/iavf_txrx.h   |  4 --
>>   8 files changed, 35 insertions(+), 118 deletions(-)
>>