| Message ID | 20230614084808.98819-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Neil Armstrong |
| Headers | show |
| Series | clk: meson: pll: remove unneeded semicolon | expand |
On Wed 14 Jun 2023 at 16:48, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > No functional modification involved. > > ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533 Not sure this tag is relevant > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Apart from this Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> > --- > drivers/clk/meson/clk-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c > index 56ec2210f1ad..8fef90bf962f 100644 > --- a/drivers/clk/meson/clk-pll.c > +++ b/drivers/clk/meson/clk-pll.c > @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw) > usleep_range(10, 20); > meson_parm_write(clk->map, &pll->current_en, 1); > usleep_range(40, 50); > - }; > + } > > if (MESON_PARM_APPLICABLE(&pll->l_detect)) { > meson_parm_write(clk->map, &pll->l_detect, 1);
On Wed, Jun 14, 2023 at 10:48 AM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > No functional modification involved. > > ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
On Wed 14 Jun 2023 at 22:09, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Wed, Jun 14, 2023 at 10:48 AM Jiapeng Chong > <jiapeng.chong@linux.alibaba.com> wrote: >> >> No functional modification involved. >> >> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon. >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533 Removed this bugzilla tag and added a fixes tag: Fixes: b6ec400aa153 ("clk: meson: introduce new pll power-on sequence for A1 SoC family") >> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Applied through the amlogic clock tree. Thx
Dear Jiapeng, Thank you for catching this bug! Appreciate it! On Wed, Jun 14, 2023 at 04:48:08PM +0800, Jiapeng Chong wrote: > No functional modification involved. > > ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/clk/meson/clk-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c > index 56ec2210f1ad..8fef90bf962f 100644 > --- a/drivers/clk/meson/clk-pll.c > +++ b/drivers/clk/meson/clk-pll.c > @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw) > usleep_range(10, 20); > meson_parm_write(clk->map, &pll->current_en, 1); > usleep_range(40, 50); > - }; > + } > > if (MESON_PARM_APPLICABLE(&pll->l_detect)) { > meson_parm_write(clk->map, &pll->l_detect, 1); Reviewed-by: Dmitry Rokosov <ddrokosov@sberdevices.ru> > -- > 2.20.1.7.g153144c > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c index 56ec2210f1ad..8fef90bf962f 100644 --- a/drivers/clk/meson/clk-pll.c +++ b/drivers/clk/meson/clk-pll.c @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw) usleep_range(10, 20); meson_parm_write(clk->map, &pll->current_en, 1); usleep_range(40, 50); - }; + } if (MESON_PARM_APPLICABLE(&pll->l_detect)) { meson_parm_write(clk->map, &pll->l_detect, 1);
No functional modification involved. ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/clk/meson/clk-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)