[v4,00/11] wifi: ath12k: (v4) EHT support

Message

Aloka Dixit June 2, 2023, 11:58 p.m. UTC

Add driver support for EHT bring-up, association and
preamble puncturing.

v4: Modified patch 3 to support WCN7850.
v3: Modified patches 6 and 9 to fix some issues,
changelog included in the respective patches.
v2: This version modifies only few commit descriptions,
changelog included in the respective patches.

Following list gives the details for each patch.
1-4: Propagation of EHT capabilities from target to userspace.
5: Addition of EHT phy modes.
6-9: EHT related additions in peer association.
10: Process the new WMI service ready ext2 event.
11: Preamble puncturing support.


Aloka Dixit (9):
  wifi: ath12k: rename HE capabilities setup/copy functions
  wifi: ath12k: move HE capabilities processing to a new function
  wifi: ath12k: WMI support to process EHT capabilities
  wifi: ath12k: propagate EHT capabilities to userspace
  wifi: ath12k: prepare EHT peer assoc parameters
  wifi: ath12k: add WMI support for EHT peer
  wifi: ath12k: peer assoc for 320 MHz
  wifi: ath12k: parse WMI service ready ext2 event
  wifi: ath12k: configure puncturing bitmap

Muna Sinada (1):
  wifi: ath12k: add EHT PHY modes

Pradeep Kumar Chitrapu (1):
  wifi: ath12k: add MLO header in peer association

 drivers/net/wireless/ath/ath12k/core.h |  17 +
 drivers/net/wireless/ath/ath12k/mac.c  | 556 ++++++++++++++++++++-----
 drivers/net/wireless/ath/ath12k/mac.h  |   2 +-
 drivers/net/wireless/ath/ath12k/wmi.c  | 252 ++++++++++-
 drivers/net/wireless/ath/ath12k/wmi.h  | 116 +++++-
 5 files changed, 833 insertions(+), 110 deletions(-)


base-commit: a4756ac34a7002861c9bdf8cf45aec53a77fb78d

Comments

Kalle Valo June 15, 2023, 11:47 a.m. UTC | #1

Aloka Dixit <[e-mail]> writes:

> Add driver support for EHT bring-up, association and
> preamble puncturing.
>
> v4: Modified patch 3 to support WCN7850.
> v3: Modified patches 6 and 9 to fix some issues,
> changelog included in the respective patches.
> v2: This version modifies only few commit descriptions,
> changelog included in the respective patches.

I did some minor changes to these patches in the pending branch, here's
a list:

* patch 3: ath12k_wmi_tlv_mac_phy_caps_ext(): remove unncessary cast and add const

* patch 3: shorten struct ath12k_wmi_mac_phy_caps_ext_params due to
  long line warning

* patch 3: improve error messages

* patch 3: move struct ath12k_fw_pdev after struct ath12k_pdev

* patch 5: ath12k_mac_get_phymode_eht(): add extra spaces, improve error messages

* patch 6: cosmetic cleanup, extra lines etc

* patch 6: ath12k_mac_set_eht_ppe_threshold(): move declarations
  to the beginning of the function

* patch 7&8: use BIT() for enum wmi_tlv_peer_flags_ext

I have two more comments which I'll send as a reply to patches. I'm
hoping to fix those in my pending branch as well so there would no need
to resend anything.

The changes are now in the pending branch, under tag
ath-pending-202306151144. Here's a link to few of those commits:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=974310a085acad9cee462b3f343e8c05185abc67

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=e4b7f51541b4ae79baa1ab9a8389fd4d9e0fe219

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=ae4b76c40bc7350d52d42de6e8633f6e52d905fb

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=3594ef351ae29788c00fad6c69d60b9a41dc1bbb

Aloka Dixit July 24, 2023, 5:43 p.m. UTC | #2

On 6/15/2023 4:47 AM, Kalle Valo wrote:
> Aloka Dixit <[e-mail]> writes:
> 
>> Add driver support for EHT bring-up, association and
>> preamble puncturing.
>>
>> v4: Modified patch 3 to support WCN7850.
>> v3: Modified patches 6 and 9 to fix some issues,
>> changelog included in the respective patches.
>> v2: This version modifies only few commit descriptions,
>> changelog included in the respective patches.
> 
> I did some minor changes to these patches in the pending branch, here's
> a list:
> 
> * patch 3: ath12k_wmi_tlv_mac_phy_caps_ext(): remove unncessary cast and add const
> 
> * patch 3: shorten struct ath12k_wmi_mac_phy_caps_ext_params due to
>    long line warning
> 
> * patch 3: improve error messages
> 
> * patch 3: move struct ath12k_fw_pdev after struct ath12k_pdev
> 
> * patch 5: ath12k_mac_get_phymode_eht(): add extra spaces, improve error messages
> 
> * patch 6: cosmetic cleanup, extra lines etc
> 
> * patch 6: ath12k_mac_set_eht_ppe_threshold(): move declarations
>    to the beginning of the function
> 
> * patch 7&8: use BIT() for enum wmi_tlv_peer_flags_ext
> 
> I have two more comments which I'll send as a reply to patches. I'm
> hoping to fix those in my pending branch as well so there would no need
> to resend anything.
> 
> The changes are now in the pending branch, under tag
> ath-pending-202306151144. Here's a link to few of those commits:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=974310a085acad9cee462b3f343e8c05185abc67
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=e4b7f51541b4ae79baa1ab9a8389fd4d9e0fe219
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=ae4b76c40bc7350d52d42de6e8633f6e52d905fb
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=3594ef351ae29788c00fad6c69d60b9a41dc1bbb
> 


Hi Kalle,

I have created a new version which fixes the comments you added 
separately for 2 patches.
Should I send those now?

Thanks.