| Message ID | 20230609143912.849995-2-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Expose reset reason through sysfs | expand |
Hi, On Fri, Jun 09, 2023 at 04:39:11PM +0200, Miquel Raynal wrote: > It is quite uncommon to use a driver helper with parameters like *pdev > and __iomem *base. It is much cleaner and close to today's standards to > provide the per-device driver structure and then access its > internals. Let's do this with at91_resete_status() before making more > modifications to this helper. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/power/reset/at91-reset.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c > index 741e44a017c3..a8a6f3997768 100644 > --- a/drivers/power/reset/at91-reset.c > +++ b/drivers/power/reset/at91-reset.c > @@ -149,11 +149,10 @@ static int at91_reset(struct notifier_block *this, unsigned long mode, > return NOTIFY_DONE; > } > > -static void __init at91_reset_status(struct platform_device *pdev, > - void __iomem *base) > +static void __init at91_reset_status(struct at91_reset *reset) > { > + u32 reg = readl(reset->rstc_base + AT91_RSTC_SR); > const char *reason; > - u32 reg = readl(base + AT91_RSTC_SR); > > switch ((reg & AT91_RSTC_RSTTYP) >> 8) { > case RESET_TYPE_GENERAL: You also need to update the code calling this functions, otherwise the series is not bisectable. -- Sebastian
Hi Sebastian, sebastian.reichel@collabora.com wrote on Sat, 10 Jun 2023 01:14:22 +0200: > Hi, > > On Fri, Jun 09, 2023 at 04:39:11PM +0200, Miquel Raynal wrote: > > It is quite uncommon to use a driver helper with parameters like *pdev > > and __iomem *base. It is much cleaner and close to today's standards to > > provide the per-device driver structure and then access its > > internals. Let's do this with at91_resete_status() before making more > > modifications to this helper. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > drivers/power/reset/at91-reset.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c > > index 741e44a017c3..a8a6f3997768 100644 > > --- a/drivers/power/reset/at91-reset.c > > +++ b/drivers/power/reset/at91-reset.c > > @@ -149,11 +149,10 @@ static int at91_reset(struct notifier_block *this, unsigned long mode, > > return NOTIFY_DONE; > > } > > > > -static void __init at91_reset_status(struct platform_device *pdev, > > - void __iomem *base) > > +static void __init at91_reset_status(struct at91_reset *reset) > > { > > + u32 reg = readl(reset->rstc_base + AT91_RSTC_SR); > > const char *reason; > > - u32 reg = readl(base + AT91_RSTC_SR); > > > > switch ((reg & AT91_RSTC_RSTTYP) >> 8) { > > case RESET_TYPE_GENERAL: > > You also need to update the code calling this functions, otherwise > the series is not bisectable. Of course, I was not paying enough attention here, sorry about that. Thanks, Miquèl
diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index 741e44a017c3..a8a6f3997768 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -149,11 +149,10 @@ static int at91_reset(struct notifier_block *this, unsigned long mode, return NOTIFY_DONE; } -static void __init at91_reset_status(struct platform_device *pdev, - void __iomem *base) +static void __init at91_reset_status(struct at91_reset *reset) { + u32 reg = readl(reset->rstc_base + AT91_RSTC_SR); const char *reason; - u32 reg = readl(base + AT91_RSTC_SR); switch ((reg & AT91_RSTC_RSTTYP) >> 8) { case RESET_TYPE_GENERAL:
It is quite uncommon to use a driver helper with parameters like *pdev and __iomem *base. It is much cleaner and close to today's standards to provide the per-device driver structure and then access its internals. Let's do this with at91_resete_status() before making more modifications to this helper. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/power/reset/at91-reset.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)