| Message ID | 20230615141349.172363-18-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support | expand |
On Thu, Jun 15, 2023 at 04:13:38PM +0200, Hans de Goede wrote: > Add an acpi_match_table now that all the other bits necessary for > ACPI support are in place. ... > +static const struct acpi_device_id ov2680_acpi_ids[] = { > + { "OVTI2680" }, > + { /* sentinel */ }, Comma is not needed for the terminator entry. > +};
Hi, On 6/15/23 16:41, Andy Shevchenko wrote: > On Thu, Jun 15, 2023 at 04:13:38PM +0200, Hans de Goede wrote: >> Add an acpi_match_table now that all the other bits necessary for >> ACPI support are in place. > > ... > >> +static const struct acpi_device_id ov2680_acpi_ids[] = { >> + { "OVTI2680" }, >> + { /* sentinel */ }, > > Comma is not needed for the terminator entry. Ack, thank you. Fixed for the next version. Regards, Hans > >> +}; >
diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c index 52ae265612fa..1dc41351b4d2 100644 --- a/drivers/media/i2c/ov2680.c +++ b/drivers/media/i2c/ov2680.c @@ -934,11 +934,18 @@ static const struct of_device_id ov2680_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, ov2680_dt_ids); +static const struct acpi_device_id ov2680_acpi_ids[] = { + { "OVTI2680" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(acpi, ov2680_acpi_ids); + static struct i2c_driver ov2680_i2c_driver = { .driver = { .name = "ov2680", .pm = pm_sleep_ptr(&ov2680_pm_ops), .of_match_table = of_match_ptr(ov2680_dt_ids), + .acpi_match_table = ov2680_acpi_ids, }, .probe = ov2680_probe, .remove = ov2680_remove,
Add an acpi_match_table now that all the other bits necessary for ACPI support are in place. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/media/i2c/ov2680.c | 7 +++++++ 1 file changed, 7 insertions(+)