diff mbox series

[v3,2/7] arm64: dts: imx93-11x11-evk: added ele-mu

Message ID 20230616181144.646500-3-pankaj.gupta@nxp.com (mailing list archive)
State New, archived
Headers show
Series firmware: imx: NXP Edgelock Enclave MUAP Driver | expand

Commit Message

Pankaj Gupta June 16, 2023, 6:11 p.m. UTC
adde support for ele-mu for imx93-11x11-evk.

Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski June 16, 2023, 1:21 p.m. UTC | #1
On 16/06/2023 20:11, Pankaj Gupta wrote:
> adde support for ele-mu for imx93-11x11-evk.
> 
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>


>  #include <dt-bindings/clock/imx93-clock.h>
> @@ -788,5 +788,15 @@ media_blk_ctrl: system-controller@4ac10000 {
>  			#power-domain-cells = <1>;
>  			status = "disabled";
>  		};
> +
> +		ele_mu: ele-mu {
> +			compatible = "fsl,imx93-ele";
> +			mboxes = <&s4muap 0 0 &s4muap 1 0>;
> +			mbox-names = "tx", "rx";
> +			fsl,ele_mu_did = <3>;
> +			fsl,ele_mu_id = <2>;
> +			fsl,ele_mu_max_users = <4>;
> +			status = "okay";

Can you do some internal review first?

Best regards,
Krzysztof
Pankaj Gupta July 10, 2023, 5:47 p.m. UTC | #2
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, June 16, 2023 6:52 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Gaurav
> Jain <gaurav.jain@nxp.com>; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v3 2/7] arm64: dts: imx93-11x11-evk: added ele-
> mu
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 16/06/2023 20:11, Pankaj Gupta wrote:
> > adde support for ele-mu for imx93-11x11-evk.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> 
> 
> >  #include <dt-bindings/clock/imx93-clock.h> @@ -788,5 +788,15 @@
> > media_blk_ctrl: system-controller@4ac10000 {
> >                       #power-domain-cells = <1>;
> >                       status = "disabled";
> >               };
> > +
> > +             ele_mu: ele-mu {
> > +                     compatible = "fsl,imx93-ele";
> > +                     mboxes = <&s4muap 0 0 &s4muap 1 0>;
> > +                     mbox-names = "tx", "rx";
> > +                     fsl,ele_mu_did = <3>;
> > +                     fsl,ele_mu_id = <2>;
> > +                     fsl,ele_mu_max_users = <4>;
> > +                     status = "okay";
> 
> Can you do some internal review first?
Done. 
- Removed non h/w dependent DT binding : " fsl,ele_mu_max_users".
- To denote the kernel driver for interacting with Secure-Enclave Firmware; re-named to "se-fw" from "ele-mu".


> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index e8d49660ac85..03ee20cf74ce 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -1,6 +1,6 @@ 
 // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
 /*
- * Copyright 2022 NXP
+ * Copyright 2022-2023 NXP
  */
 
 #include <dt-bindings/clock/imx93-clock.h>
@@ -788,5 +788,15 @@  media_blk_ctrl: system-controller@4ac10000 {
 			#power-domain-cells = <1>;
 			status = "disabled";
 		};
+
+		ele_mu: ele-mu {
+			compatible = "fsl,imx93-ele";
+			mboxes = <&s4muap 0 0 &s4muap 1 0>;
+			mbox-names = "tx", "rx";
+			fsl,ele_mu_did = <3>;
+			fsl,ele_mu_id = <2>;
+			fsl,ele_mu_max_users = <4>;
+			status = "okay";
+		};
 	};
 };