| Message ID | 20230530112746.2767-1-lihuisong@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: hisilicon: Support HCCS driver on Kunpeng SoC | expand |
Hi all, Kindly ping. 在 2023/5/30 19:27, Huisong Li 写道: > This series add HCCS driver to query the health status and port information > of HCCS on Kunpeng SoC as well as document all sysfs entries provided by > this driver. > > --- > v3: > - replace "using_status" with "enable" attribute. > - fix some comments in codes. > > --- > v2: > - Document all sysfs entries provided by driver. > - drop 'pcc_type' and 'intr_mode' in struct hccs_dev. > - using _CRS with PCC GAS to get channel ID instead of _DSD. > - replace readw_relaxed_poll_timeout with readw_poll_timeout. > - use sysfs_emit() instead of sprintf(). > - drop ACPI_PTR in hccs_driver. > - drop useless log during the probe phase. > > Huisong Li (2): > soc: hisilicon: Support HCCS driver on Kunpeng SoC > doc: soc: hisilicon: Add Kunpeng HCCS driver documentation > > .../sysfs-devices-platform-kunpeng_hccs | 76 + > MAINTAINERS | 7 + > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/hisilicon/Kconfig | 19 + > drivers/soc/hisilicon/Makefile | 2 + > drivers/soc/hisilicon/kunpeng_hccs.c | 1288 +++++++++++++++++ > drivers/soc/hisilicon/kunpeng_hccs.h | 196 +++ > 8 files changed, 1590 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-devices-platform-kunpeng_hccs > create mode 100644 drivers/soc/hisilicon/Kconfig > create mode 100644 drivers/soc/hisilicon/Makefile > create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.c > create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.h >
Hi all, Can you take a look at this series? 在 2023/5/30 19:27, Huisong Li 写道: > This series add HCCS driver to query the health status and port information > of HCCS on Kunpeng SoC as well as document all sysfs entries provided by > this driver. > > --- > v3: > - replace "using_status" with "enable" attribute. > - fix some comments in codes. > > --- > v2: > - Document all sysfs entries provided by driver. > - drop 'pcc_type' and 'intr_mode' in struct hccs_dev. > - using _CRS with PCC GAS to get channel ID instead of _DSD. > - replace readw_relaxed_poll_timeout with readw_poll_timeout. > - use sysfs_emit() instead of sprintf(). > - drop ACPI_PTR in hccs_driver. > - drop useless log during the probe phase. > > Huisong Li (2): > soc: hisilicon: Support HCCS driver on Kunpeng SoC > doc: soc: hisilicon: Add Kunpeng HCCS driver documentation > > .../sysfs-devices-platform-kunpeng_hccs | 76 + > MAINTAINERS | 7 + > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/hisilicon/Kconfig | 19 + > drivers/soc/hisilicon/Makefile | 2 + > drivers/soc/hisilicon/kunpeng_hccs.c | 1288 +++++++++++++++++ > drivers/soc/hisilicon/kunpeng_hccs.h | 196 +++ > 8 files changed, 1590 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-devices-platform-kunpeng_hccs > create mode 100644 drivers/soc/hisilicon/Kconfig > create mode 100644 drivers/soc/hisilicon/Makefile > create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.c > create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.h >
On 14/07/2023 08:17, lihuisong (C) wrote: > Hi all, > > Can you take a look at this series? People you listed in "To:" field are not maintainers of HiSilicon, so why pinging us? HiSilicon DTS has numerous issues, so if you want to increase the chances anyone cares about your patch, please contribute to fixing and improving your company DTS. See for example commit b2bbc8687 which is bad (underscores are not allowed) or 1860a51823 which is just wrong. The latter one is being fixed, although I do not see the fix being picked up... my feelings are the platform is just dead. Best regards, Krzysztof
Hi Krzysztof, Thank you for your reply. 在 2023/7/17 20:06, Krzysztof Kozlowski 写道: > On 14/07/2023 08:17, lihuisong (C) wrote: >> Hi all, >> >> Can you take a look at this series? > People you listed in "To:" field are not maintainers of HiSilicon, so > why pinging us? This "To:" field are from the get_maintainer.pl script. ./scripts/get_maintainer.pl -f ./drivers/soc/ The hisilicon in drivers/soc/ is created for the first time. So there are no maintainer of HiSilicon. Thanks for reminder. add HiSilicon SOC maintainer Wei Xu. > > HiSilicon DTS has numerous issues, so if you want to increase the > chances anyone cares about your patch, please contribute to fixing and > improving your company DTS. See for example commit b2bbc8687 which is > bad (underscores are not allowed) or 1860a51823 which is just wrong. The > latter one is being fixed, although I do not see the fix being picked > up... my feelings are the platform is just dead. The HCCS driver has nothing to do with HiSilicon DTS. So I cannot understand why you say DTS. /Huisong
On 18/07/2023 10:07, lihuisong (C) wrote: > Hi Krzysztof, > > Thank you for your reply. > > > 在 2023/7/17 20:06, Krzysztof Kozlowski 写道: >> On 14/07/2023 08:17, lihuisong (C) wrote: >>> Hi all, >>> >>> Can you take a look at this series? >> People you listed in "To:" field are not maintainers of HiSilicon, so >> why pinging us? > This "To:" field are from the get_maintainer.pl script. > ./scripts/get_maintainer.pl -f ./drivers/soc/ Which is not really correct. Why would you send it to maintainers of Samsung or NXP? > The hisilicon in drivers/soc/ is created for the first time. So there > are no maintainer of HiSilicon. There are. Open MAINTAINERS file, use search and voila. > > Thanks for reminder. > add HiSilicon SOC maintainer Wei Xu. >> >> HiSilicon DTS has numerous issues, so if you want to increase the >> chances anyone cares about your patch, please contribute to fixing and >> improving your company DTS. See for example commit b2bbc8687 which is >> bad (underscores are not allowed) or 1860a51823 which is just wrong. The >> latter one is being fixed, although I do not see the fix being picked >> up... my feelings are the platform is just dead. > The HCCS driver has nothing to do with HiSilicon DTS. > So I cannot understand why you say DTS. I grunted about poor support for HiSilicon. Because both - HiSilicon DTS and HiSilicon SoC HCCS driver - are for HiSilicon. Now, why don't you help the maintainers review/fix stuff so they will have more time for your patch? Best regards, Krzysztof
Hi Krzysztof, On 2023/7/18 16:07, lihuisong (C) wrote: > Hi Krzysztof, > > Thank you for your reply. > > > 在 2023/7/17 20:06, Krzysztof Kozlowski 写道: >> On 14/07/2023 08:17, lihuisong (C) wrote: >>> Hi all, >>> >>> Can you take a look at this series? >> People you listed in "To:" field are not maintainers of HiSilicon, so >> why pinging us? > This "To:" field are from the get_maintainer.pl script. > ./scripts/get_maintainer.pl -f ./drivers/soc/ > The hisilicon in drivers/soc/ is created for the first time. So there are no maintainer of HiSilicon. > > Thanks for reminder. > add HiSilicon SOC maintainer Wei Xu. >> >> HiSilicon DTS has numerous issues, so if you want to increase the >> chances anyone cares about your patch, please contribute to fixing and >> improving your company DTS. See for example commit b2bbc8687 which is >> bad (underscores are not allowed) or 1860a51823 which is just wrong. The >> latter one is being fixed, although I do not see the fix being picked Sorry, it seems wrong of the commit 1860a51823 which changed the clock pin. I have checked the mail list but did not find the bug fix for it. Could you please kindly share the subject of the patch? Or I can simply revert it. Thanks! Best Regards, Wei >> up... my feelings are the platform is just dead. > The HCCS driver has nothing to do with HiSilicon DTS. > So I cannot understand why you say DTS. > > /Huisong > . >
在 2023/7/18 18:59, Krzysztof Kozlowski 写道: > On 18/07/2023 10:07, lihuisong (C) wrote: >> Hi Krzysztof, >> >> Thank you for your reply. >> >> >> 在 2023/7/17 20:06, Krzysztof Kozlowski 写道: >>> On 14/07/2023 08:17, lihuisong (C) wrote: >>>> Hi all, >>>> >>>> Can you take a look at this series? >>> People you listed in "To:" field are not maintainers of HiSilicon, so >>> why pinging us? >> This "To:" field are from the get_maintainer.pl script. >> ./scripts/get_maintainer.pl -f ./drivers/soc/ > Which is not really correct. Why would you send it to maintainers of > Samsung or NXP? Yeah, that's not entirely correct. I should skip other SOC maintainers from the output of the script. The reason why I send to some maintainers in "To" field is that some of them have kindly reviewed my patch before. > >> The hisilicon in drivers/soc/ is created for the first time. So there >> are no maintainer of HiSilicon. > There are. Open MAINTAINERS file, use search and voila. got it, thanks. > >> Thanks for reminder. >> add HiSilicon SOC maintainer Wei Xu. >>> HiSilicon DTS has numerous issues, so if you want to increase the >>> chances anyone cares about your patch, please contribute to fixing and >>> improving your company DTS. See for example commit b2bbc8687 which is >>> bad (underscores are not allowed) or 1860a51823 which is just wrong. The >>> latter one is being fixed, although I do not see the fix being picked >>> up... my feelings are the platform is just dead. >> The HCCS driver has nothing to do with HiSilicon DTS. >> So I cannot understand why you say DTS. > I grunted about poor support for HiSilicon. Because both - HiSilicon DTS > and HiSilicon SoC HCCS driver - are for HiSilicon. This driver works on kunpneg SOC platform, which isn't related to something you mentioned. > > Now, why don't you help the maintainers review/fix stuff so they will > have more time for your patch? Yes, this is helpful and reasonable. Would do it if I have the chance. Best regards, Huisong
Hi All, Now I add HiSilicon SOC maintainer Wei Xu attributing to Krzysztof's reminder. Thanks for your review. All comments have been closed. Could you please kindly confirm my modifications for your comments? If it is ok for you. In order to go on smoothly, can you reply?