| Message ID | 20230610090414.90529-1-avromanov@sberdevices.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] drivers: meson: secure-pwrc: always enable DMA domain | expand |
On 10/06/2023 11:04, Alexey Romanov wrote: > Starting from commit e45f243409db ("firmware: meson_sm: > populate platform devices from sm device tree data") pwrc > is probed successfully and disables unused pwr domains. > By A1 SoC family design, any TEE requires DMA pwr domain > always enabled. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > I'm not entirely sure if this domain should always be enabled on or it > should be separately enabled in dts file. Comments are welcome. > --- > drivers/soc/amlogic/meson-secure-pwrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c > index e93518763526..25b4b71df9b8 100644 > --- a/drivers/soc/amlogic/meson-secure-pwrc.c > +++ b/drivers/soc/amlogic/meson-secure-pwrc.c > @@ -105,7 +105,7 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = { > SEC_PD(ACODEC, 0), > SEC_PD(AUDIO, 0), > SEC_PD(OTP, 0), > - SEC_PD(DMA, 0), > + SEC_PD(DMA, GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE), > SEC_PD(SD_EMMC, 0), > SEC_PD(RAMA, 0), > /* SRAMB is used as ATF runtime memory, and should be always on */ It's fine to keep it enabled. Acked-by: Neil Armstrong <neil.armstrong@linaro.org> Neil
Hi, On Sat, 10 Jun 2023 12:04:14 +0300, Alexey Romanov wrote: > Starting from commit e45f243409db ("firmware: meson_sm: > populate platform devices from sm device tree data") pwrc > is probed successfully and disables unused pwr domains. > By A1 SoC family design, any TEE requires DMA pwr domain > always enabled. > > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.5/drivers) [1/1] drivers: meson: secure-pwrc: always enable DMA domain https://git.kernel.org/amlogic/c/0bb4644d583789c97e74d3e3047189f0c59c4742 These changes has been applied on the intermediate git tree [1]. The v6.5/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c index e93518763526..25b4b71df9b8 100644 --- a/drivers/soc/amlogic/meson-secure-pwrc.c +++ b/drivers/soc/amlogic/meson-secure-pwrc.c @@ -105,7 +105,7 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = { SEC_PD(ACODEC, 0), SEC_PD(AUDIO, 0), SEC_PD(OTP, 0), - SEC_PD(DMA, 0), + SEC_PD(DMA, GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE), SEC_PD(SD_EMMC, 0), SEC_PD(RAMA, 0), /* SRAMB is used as ATF runtime memory, and should be always on */
Starting from commit e45f243409db ("firmware: meson_sm: populate platform devices from sm device tree data") pwrc is probed successfully and disables unused pwr domains. By A1 SoC family design, any TEE requires DMA pwr domain always enabled. Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> --- I'm not entirely sure if this domain should always be enabled on or it should be separately enabled in dts file. Comments are welcome. --- drivers/soc/amlogic/meson-secure-pwrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)