| Message ID | 20230619125404.562137-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: defconfig: enable Qualcomm MSM8996 Global Clock Controller as built-in | expand |
On 19.06.2023 14:54, Dmitry Baryshkov wrote: > The commit 8f680c287445 ("arm64: defconfig: Switch msm8996 clk drivers > to module") switched CONFIG_MSM_MMCC_8996 to module, which also resulted > in CONFIG_MSM_GCC_8996 being switched to module. This breaks useful > bootflow for Qualcomm MSM8996 / APQ8096 platforms, because the serial is > not enabled anymore until the GCC module is loaded. > > Reported-by: Rob Clark <robdclark@gmail.com> > Fixes: 8f680c287445 ("arm64: defconfig: Switch msm8996 clk drivers to module") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index f72d0f915340..2bff20171792 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1161,6 +1161,7 @@ CONFIG_IPQ_GCC_8074=y > CONFIG_IPQ_GCC_9574=y > CONFIG_MSM_GCC_8916=y > CONFIG_MSM_GCC_8994=y > +CONFIG_MSM_GCC_8996=y > CONFIG_MSM_MMCC_8994=m > CONFIG_MSM_MMCC_8996=m > CONFIG_MSM_MMCC_8998=m
On Mon, 19 Jun 2023 15:54:04 +0300, Dmitry Baryshkov wrote: > The commit 8f680c287445 ("arm64: defconfig: Switch msm8996 clk drivers > to module") switched CONFIG_MSM_MMCC_8996 to module, which also resulted > in CONFIG_MSM_GCC_8996 being switched to module. This breaks useful > bootflow for Qualcomm MSM8996 / APQ8096 platforms, because the serial is > not enabled anymore until the GCC module is loaded. > > > [...] Applied, thanks! [1/1] arm64: defconfig: enable Qualcomm MSM8996 Global Clock Controller as built-in commit: dc015a3a6d6986c41a7bd12fb205a282f685e328 Best regards,
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f72d0f915340..2bff20171792 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1161,6 +1161,7 @@ CONFIG_IPQ_GCC_8074=y CONFIG_IPQ_GCC_9574=y CONFIG_MSM_GCC_8916=y CONFIG_MSM_GCC_8994=y +CONFIG_MSM_GCC_8996=y CONFIG_MSM_MMCC_8994=m CONFIG_MSM_MMCC_8996=m CONFIG_MSM_MMCC_8998=m
The commit 8f680c287445 ("arm64: defconfig: Switch msm8996 clk drivers to module") switched CONFIG_MSM_MMCC_8996 to module, which also resulted in CONFIG_MSM_GCC_8996 being switched to module. This breaks useful bootflow for Qualcomm MSM8996 / APQ8096 platforms, because the serial is not enabled anymore until the GCC module is loaded. Reported-by: Rob Clark <robdclark@gmail.com> Fixes: 8f680c287445 ("arm64: defconfig: Switch msm8996 clk drivers to module") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)