| Message ID | 20230620070206.1320-1-darinzon@amazon.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1,net-next] net: ena: Add missing newline after markup | expand |
On Tue, Jun 20, 2023 at 07:02:06AM +0000, darinzon@amazon.com wrote: > From: David Arinzon <darinzon@amazon.com> > > This patch fixes a warning in the ena documentation > file identified by the kernel automatic tools. > > Signed-off-by: David Arinzon <darinzon@amazon.com> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel.com/ > --- > Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > index 491492677632..00851ec7b4ec 100644 > --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > +++ b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > @@ -206,6 +206,7 @@ More information about Adaptive Interrupt Moderation (DIM) can be found in > Documentation/networking/net_dim.rst > > .. _`RX copybreak`: > + > RX copybreak > ============ > The rx_copybreak is initialized by default to ENA_DEFAULT_RX_COPYBREAK Thanks David, this looks good to me. Reviewed-by: Simon Horman <simon.horman@corigine.com> Although it doesn't trigger a warning, the formatting of the text updated below doesn't seem right (I used make htmldocs). Feel free to take this if it is useful, or say the word and I'll submit it formally. diff --git a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst index 00851ec7b4ec..5eaa3ab6c73e 100644 --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst +++ b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst @@ -38,6 +38,7 @@ debug logs. Some of the ENA devices support a working mode called Low-latency Queue (LLQ), which saves several more microseconds. + ENA Source Code Directory Structure ===================================
> On Tue, Jun 20, 2023 at 07:02:06AM +0000, darinzon@amazon.com wrote: > > From: David Arinzon <darinzon@amazon.com> > > > > This patch fixes a warning in the ena documentation file identified by > > the kernel automatic tools. > > > > Signed-off-by: David Arinzon <darinzon@amazon.com> > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel. > > com/ > > --- > > Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1 > + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > > index 491492677632..00851ec7b4ec 100644 > > --- > a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > > +++ > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > > @@ -206,6 +206,7 @@ More information about Adaptive Interrupt > > Moderation (DIM) can be found in > Documentation/networking/net_dim.rst > > > > .. _`RX copybreak`: > > + > > RX copybreak > > ============ > > The rx_copybreak is initialized by default to > > ENA_DEFAULT_RX_COPYBREAK > > Thanks David, > > this looks good to me. > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > Although it doesn't trigger a warning, the formatting of the text updated > below doesn't seem right (I used make htmldocs). > Feel free to take this if it is useful, or say the word and I'll submit it formally. > > diff --git > a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > index 00851ec7b4ec..5eaa3ab6c73e 100644 > --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > +++ > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst > @@ -38,6 +38,7 @@ debug logs. > > Some of the ENA devices support a working mode called Low-latency > Queue (LLQ), which saves several more microseconds. > + > ENA Source Code Directory Structure > =================================== > > Hi Simon, Thank you for reviewing and identifying this formatting issue, I'll submit a v2 today.
diff --git a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst index 491492677632..00851ec7b4ec 100644 --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst +++ b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst @@ -206,6 +206,7 @@ More information about Adaptive Interrupt Moderation (DIM) can be found in Documentation/networking/net_dim.rst .. _`RX copybreak`: + RX copybreak ============ The rx_copybreak is initialized by default to ENA_DEFAULT_RX_COPYBREAK