| Message ID | 20230620175506.263109-1-contact@emersion.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge_connector: use drm_kms_helper_connector_hotplug_event() | expand |
Hi Simon, Thank you for the patch. On Tue, Jun 20, 2023 at 05:55:09PM +0000, Simon Ser wrote: > This adds more information to the hotplug uevent and lets user-space > know that it's about a particular connector only. > > Signed-off-by: Simon Ser <contact@emersion.fr> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Paul Cercueil <paul@crapouillou.net> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/drm_bridge_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index 19ae4a177ac3..fc6f16e14f36 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -125,7 +125,7 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, > > drm_bridge_connector_hpd_notify(connector, status); > > - drm_kms_helper_hotplug_event(dev); > + drm_kms_helper_connector_hotplug_event(connector); > } > > static void drm_bridge_connector_enable_hpd(struct drm_connector *connector)
Hi Simon, On Tue, Jun 20, 2023 at 05:55:09PM +0000, Simon Ser wrote: > This adds more information to the hotplug uevent and lets user-space > know that it's about a particular connector only. Will this change have impact on user space? They will start to see CONNECTOR=n where they did not occur before. Asking as I have not really worked with the hotplug stuff. The code change looks fine - no comment there. And if there are no user space worries then: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Sam > > Signed-off-by: Simon Ser <contact@emersion.fr> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Paul Cercueil <paul@crapouillou.net> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/gpu/drm/drm_bridge_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index 19ae4a177ac3..fc6f16e14f36 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -125,7 +125,7 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, > > drm_bridge_connector_hpd_notify(connector, status); > > - drm_kms_helper_hotplug_event(dev); > + drm_kms_helper_connector_hotplug_event(connector); > } > > static void drm_bridge_connector_enable_hpd(struct drm_connector *connector) > -- > 2.41.0 >
On Tuesday, June 20th, 2023 at 20:58, Sam Ravnborg <sam@ravnborg.org> wrote: > On Tue, Jun 20, 2023 at 05:55:09PM +0000, Simon Ser wrote: > > > This adds more information to the hotplug uevent and lets user-space > > know that it's about a particular connector only. > > Will this change have impact on user space? > They will start to see CONNECTOR=n where they did not occur before. > Asking as I have not really worked with the hotplug stuff. Yes. CONNECTOR is an optional udev event property indicating that only the specified connector has changed. User-space unaware of this property will just ignore it. User-space aware of this property will only refresh information about the connector instead of the whole device. A few months back, we've converted calls to drm_kms_helper_connector_hotplug_event() in amdgpu and the DRM DP helper.
Hi Simon, On Tue, Jun 20, 2023 at 07:01:59PM +0000, Simon Ser wrote: > On Tuesday, June 20th, 2023 at 20:58, Sam Ravnborg <sam@ravnborg.org> wrote: > > > On Tue, Jun 20, 2023 at 05:55:09PM +0000, Simon Ser wrote: > > > > > This adds more information to the hotplug uevent and lets user-space > > > know that it's about a particular connector only. > > > > Will this change have impact on user space? > > They will start to see CONNECTOR=n where they did not occur before. > > Asking as I have not really worked with the hotplug stuff. > > Yes. CONNECTOR is an optional udev event property indicating that only > the specified connector has changed. User-space unaware of this > property will just ignore it. User-space aware of this property will > only refresh information about the connector instead of the whole > device. > > A few months back, we've converted calls to > drm_kms_helper_connector_hotplug_event() in amdgpu and the DRM DP > helper. Thanks for the explanation - all is good. Sam
diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c index 19ae4a177ac3..fc6f16e14f36 100644 --- a/drivers/gpu/drm/drm_bridge_connector.c +++ b/drivers/gpu/drm/drm_bridge_connector.c @@ -125,7 +125,7 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, drm_bridge_connector_hpd_notify(connector, status); - drm_kms_helper_hotplug_event(dev); + drm_kms_helper_connector_hotplug_event(connector); } static void drm_bridge_connector_enable_hpd(struct drm_connector *connector)
This adds more information to the hotplug uevent and lets user-space know that it's about a particular connector only. Signed-off-by: Simon Ser <contact@emersion.fr> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Paul Cercueil <paul@crapouillou.net> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Sam Ravnborg <sam@ravnborg.org> --- drivers/gpu/drm/drm_bridge_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)