diff mbox series

[net,v1] Revert "net: phy: dp83867: perform soft reset and retain established link"

Message ID 20230619154435.355485-1-francesco@dolcini.it (mailing list archive)
State Accepted
Commit a129b41fe0a8b4da828c46b10f5244ca07a3fec3
Delegated to: Netdev Maintainers
Headers show
Series [net,v1] Revert "net: phy: dp83867: perform soft reset and retain established link" | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Francesco Dolcini June 19, 2023, 3:44 p.m. UTC 
From: Francesco Dolcini <francesco.dolcini@toradex.com>

This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.

This fixes a regression in which the link would come up, but no
communication was possible.

The reverted commit was also removing a comment about
DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
since it seems that this is unrelated to the original code change.

Cc: Praneeth Bajjuri <praneeth@ti.com>
Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 drivers/net/phy/dp83867.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn June 19, 2023, 4:30 p.m. UTC | #1 
On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
> 
> This fixes a regression in which the link would come up, but no
> communication was possible.
> 
> The reverted commit was also removing a comment about
> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
> since it seems that this is unrelated to the original code change.
> 
> Cc: Praneeth Bajjuri <praneeth@ti.com>
> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

There has been plenty of time given for somebody to investigate this
regression, and nothing has happened. So i agree, lets revert it.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Bajjuri, Praneeth June 19, 2023, 7:49 p.m. UTC | #2 
On 6/19/2023 11:30 AM, Andrew Lunn wrote:
> On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>
>> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>>
>> This fixes a regression in which the link would come up, but no
>> communication was possible.
>>
>> The reverted commit was also removing a comment about
>> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
>> since it seems that this is unrelated to the original code change.
>>
>> Cc: Praneeth Bajjuri <praneeth@ti.com>
>> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
>> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> There has been plenty of time given for somebody to investigate this
> regression, and nothing has happened. So i agree, lets revert it.
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Agreed to revert.

Reviewed-by: Praneeth Bajjuri <praneeth@ti.com>


> 
>      Andrew
patchwork-bot+netdevbpf@kernel.org June 21, 2023, 3:40 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 19 Jun 2023 17:44:35 +0200 you wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
> 
> This fixes a regression in which the link would come up, but no
> communication was possible.
> 
> [...]

Here is the summary with links:
  - [net,v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
    https://git.kernel.org/netdev/net/c/a129b41fe0a8

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 76f5a2402fb0..e397e7d642d9 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -936,7 +936,7 @@  static int dp83867_phy_reset(struct phy_device *phydev)
 {
 	int err;
 
-	err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART);
+	err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET);
 	if (err < 0)
 		return err;