| Message ID | 20230620203915.141337-2-quic_bjorande@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3 GPIO | expand |
On 20.06.2023 22:39, Bjorn Andersson wrote: > The external regulators in the CRD seems to have inherited their names > from the X13s DeviceTree, correct them. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Please also update the node names to match. Konrad > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index b21b41a066b6..678cdf253f2e 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -133,7 +133,7 @@ vreg_edp_3p3: regulator-edp-3p3 { > vreg_edp_bl: regulator-edp-bl { > compatible = "regulator-fixed"; > > - regulator-name = "VBL9"; > + regulator-name = "VREG_EDP_BL"; > regulator-min-microvolt = <3600000>; > regulator-max-microvolt = <3600000>; > > @@ -149,7 +149,7 @@ vreg_edp_bl: regulator-edp-bl { > vreg_nvme: regulator-nvme { > compatible = "regulator-fixed"; > > - regulator-name = "VCC3_SSD"; > + regulator-name = "VREG_NVME_3P3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > > @@ -163,7 +163,7 @@ vreg_nvme: regulator-nvme { > vreg_misc_3p3: regulator-misc-3p3 { > compatible = "regulator-fixed"; > > - regulator-name = "VCC3B"; > + regulator-name = "VREG_MISC_3P3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > > @@ -180,7 +180,7 @@ vreg_misc_3p3: regulator-misc-3p3 { > vreg_wlan: regulator-wlan { > compatible = "regulator-fixed"; > > - regulator-name = "VCC_WLAN_3R9"; > + regulator-name = "VPH_PWR_WLAN"; > regulator-min-microvolt = <3900000>; > regulator-max-microvolt = <3900000>; > > @@ -196,7 +196,7 @@ vreg_wlan: regulator-wlan { > vreg_wwan: regulator-wwan { > compatible = "regulator-fixed"; > > - regulator-name = "VCC3B_WAN"; > + regulator-name = "SDX_VPH_PWR"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; >
On Tue, Jun 20, 2023 at 10:42:12PM +0200, Konrad Dybcio wrote: > On 20.06.2023 22:39, Bjorn Andersson wrote: > > The external regulators in the CRD seems to have inherited their names > > from the X13s DeviceTree, correct them. > > > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > > --- > Please also update the node names to match. I don't think that's necessary in this case. The labels and node names currently used are either close enough or more descriptive. Johan
On Tue, Jun 20, 2023 at 01:39:15PM -0700, Bjorn Andersson wrote: > The external regulators in the CRD seems to have inherited their names > from the X13s DeviceTree, correct them. Yeah, without access to the schematics that's a guess as good as anything. Fortunately, you're there to dig out the names. :) > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index b21b41a066b6..678cdf253f2e 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -133,7 +133,7 @@ vreg_edp_3p3: regulator-edp-3p3 { vreg_edp_bl: regulator-edp-bl { compatible = "regulator-fixed"; - regulator-name = "VBL9"; + regulator-name = "VREG_EDP_BL"; regulator-min-microvolt = <3600000>; regulator-max-microvolt = <3600000>; @@ -149,7 +149,7 @@ vreg_edp_bl: regulator-edp-bl { vreg_nvme: regulator-nvme { compatible = "regulator-fixed"; - regulator-name = "VCC3_SSD"; + regulator-name = "VREG_NVME_3P3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; @@ -163,7 +163,7 @@ vreg_nvme: regulator-nvme { vreg_misc_3p3: regulator-misc-3p3 { compatible = "regulator-fixed"; - regulator-name = "VCC3B"; + regulator-name = "VREG_MISC_3P3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; @@ -180,7 +180,7 @@ vreg_misc_3p3: regulator-misc-3p3 { vreg_wlan: regulator-wlan { compatible = "regulator-fixed"; - regulator-name = "VCC_WLAN_3R9"; + regulator-name = "VPH_PWR_WLAN"; regulator-min-microvolt = <3900000>; regulator-max-microvolt = <3900000>; @@ -196,7 +196,7 @@ vreg_wlan: regulator-wlan { vreg_wwan: regulator-wwan { compatible = "regulator-fixed"; - regulator-name = "VCC3B_WAN"; + regulator-name = "SDX_VPH_PWR"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>;
The external regulators in the CRD seems to have inherited their names from the X13s DeviceTree, correct them. Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)