[0/2] pnv/xive2: Fix TIMA special ops detection

Message

Frederic Barrat June 21, 2023, 4:03 p.m. UTC

Fix the TIMA special ops detection regression, as spotted by Coverity.

Tested by running a pseries guest on top of a powernv9 and powernv10 host.

Frederic Barrat (2):
  pnv/xive2: Add a get_config() method on the presenter class
  pnv/xive2: Check TIMA special ops against a dedicated array for P10

 hw/intc/pnv_xive.c    | 11 +++++++++
 hw/intc/pnv_xive2.c   | 44 +++++++++------------------------
 hw/intc/xive.c        | 57 +++++++++++++++++++++++++++++++++++++------
 include/hw/ppc/xive.h |  3 +++
 4 files changed, 75 insertions(+), 40 deletions(-)

Comments

Cédric Le Goater June 21, 2023, 5:23 p.m. UTC | #1

On 6/21/23 18:03, Frederic Barrat wrote:
> Fix the TIMA special ops detection regression, as spotted by Coverity.
> 
> Tested by running a pseries guest on top of a powernv9 and powernv10 host.

FYI,

It is possible to force Gen1 on XIVE2 also. It you set the "capabilities"
property on the command line :

   -global driver=pnv-xive2,property=capabilities,value=0x1000120076f000FC

OPAL should self adapt and QEMU will probably crash ...

C.

> 
> Frederic Barrat (2):
>    pnv/xive2: Add a get_config() method on the presenter class
>    pnv/xive2: Check TIMA special ops against a dedicated array for P10
> 
>   hw/intc/pnv_xive.c    | 11 +++++++++
>   hw/intc/pnv_xive2.c   | 44 +++++++++------------------------
>   hw/intc/xive.c        | 57 +++++++++++++++++++++++++++++++++++++------
>   include/hw/ppc/xive.h |  3 +++
>   4 files changed, 75 insertions(+), 40 deletions(-)
>

Frederic Barrat June 21, 2023, 5:37 p.m. UTC | #2

On 21/06/2023 19:23, Cédric Le Goater wrote:
> FYI,
> 
> It is possible to force Gen1 on XIVE2 also. It you set the "capabilities"
> property on the command line :
> 
>    -global driver=pnv-xive2,property=capabilities,value=0x1000120076f000FC


Thanks, I hadn't noticed. And "config" too! Good to know...

   Fred