| Message ID | 20230618000856.1714902-3-mizhang@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: Documentation: Update document description for kvm_mmu_page and kvm_mmu_page_role | expand |
On Sun, 2023-06-18 at 00:08 +0000, Mingwei Zhang wrote: > Update the 'gfns' in kvm_mmu_page to 'shadowed_translation'to be consistent > with the code. The more detailed description of 'shadowed_translation' is > already inlined in the data structure definition, so no need to duplicate > the text but simply just update the name. > > Signed-off-by: Mingwei Zhang <mizhang@google.com> > --- > Documentation/virt/kvm/x86/mmu.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst > index 561efa8ec7d7..149dd3cba48f 100644 > --- a/Documentation/virt/kvm/x86/mmu.rst > +++ b/Documentation/virt/kvm/x86/mmu.rst > @@ -221,7 +221,7 @@ Shadow pages contain the following information: > at __pa(sp2->spt). sp2 will point back at sp1 through parent_pte. > The spt array forms a DAG structure with the shadow page as a node, and > guest pages as leaves. > - gfns: > + shadowed_translation: > An array of 512 guest frame numbers, one for each present pte. Used to > perform a reverse map from a pte to a gfn. When role.direct is set, any > element of this array can be calculated from the gfn field when used, in Reviewed-by: Kai Huang <kai.huang@intel.com>
On 2023-06-18 at 00:08:52 +0000, Mingwei Zhang wrote: > Update the 'gfns' in kvm_mmu_page to 'shadowed_translation'to be consistent > with the code. The more detailed description of 'shadowed_translation' is > already inlined in the data structure definition, so no need to duplicate > the text but simply just update the name. The definition of this field is changed, but apprently the description here is for gfns. It leaves some confusion if we just leave them unchanged. > > Signed-off-by: Mingwei Zhang <mizhang@google.com> > --- > Documentation/virt/kvm/x86/mmu.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst > index 561efa8ec7d7..149dd3cba48f 100644 > --- a/Documentation/virt/kvm/x86/mmu.rst > +++ b/Documentation/virt/kvm/x86/mmu.rst > @@ -221,7 +221,7 @@ Shadow pages contain the following information: > at __pa(sp2->spt). sp2 will point back at sp1 through parent_pte. > The spt array forms a DAG structure with the shadow page as a node, and > guest pages as leaves. > - gfns: > + shadowed_translation: > An array of 512 guest frame numbers, one for each present pte. Used to guest frame numbers -> shadow translation info (gfn + access) > perform a reverse map from a pte to a gfn. When role.direct is set, any Just "perform reverse mapping" is OK? > element of this array can be calculated from the gfn field when used, in May remove the "of gfns" Thanks, Yilun > -- > 2.41.0.162.gfafddb0af9-goog >
On 2023-06-23 at 08:30:54 +0800, Xu Yilun wrote: > On 2023-06-18 at 00:08:52 +0000, Mingwei Zhang wrote: > > Update the 'gfns' in kvm_mmu_page to 'shadowed_translation'to be consistent > > with the code. The more detailed description of 'shadowed_translation' is > > already inlined in the data structure definition, so no need to duplicate > > the text but simply just update the name. > > The definition of this field is changed, but apprently the description > here is for gfns. It leaves some confusion if we just leave them > unchanged. > > > > > Signed-off-by: Mingwei Zhang <mizhang@google.com> > > --- > > Documentation/virt/kvm/x86/mmu.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst > > index 561efa8ec7d7..149dd3cba48f 100644 > > --- a/Documentation/virt/kvm/x86/mmu.rst > > +++ b/Documentation/virt/kvm/x86/mmu.rst > > @@ -221,7 +221,7 @@ Shadow pages contain the following information: > > at __pa(sp2->spt). sp2 will point back at sp1 through parent_pte. > > The spt array forms a DAG structure with the shadow page as a node, and > > guest pages as leaves. > > - gfns: > > + shadowed_translation: > > An array of 512 guest frame numbers, one for each present pte. Used to > > guest frame numbers -> shadow translation info (gfn + access) > > > perform a reverse map from a pte to a gfn. When role.direct is set, any > > Just "perform reverse mapping" is OK? > > > element of this array can be calculated from the gfn field when used, in > > May remove the "of gfns" Sorry, forgot to append the original sentence. element of this array can be calculated from the gfn field when used, in this case, the array of gfns is not allocated. See role.direct and gfn. ^ May remove the "of gfns" Thanks, Yilun > > > -- > > 2.41.0.162.gfafddb0af9-goog > >
On Fri, Jun 23, 2023, Xu Yilun wrote: > On 2023-06-18 at 00:08:52 +0000, Mingwei Zhang wrote: > > Update the 'gfns' in kvm_mmu_page to 'shadowed_translation'to be consistent > > with the code. The more detailed description of 'shadowed_translation' is > > already inlined in the data structure definition, so no need to duplicate > > the text but simply just update the name. > > The definition of this field is changed, but apprently the description > here is for gfns. It leaves some confusion if we just leave them > unchanged. > > > > > Signed-off-by: Mingwei Zhang <mizhang@google.com> > > --- > > Documentation/virt/kvm/x86/mmu.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst > > index 561efa8ec7d7..149dd3cba48f 100644 > > --- a/Documentation/virt/kvm/x86/mmu.rst > > +++ b/Documentation/virt/kvm/x86/mmu.rst > > @@ -221,7 +221,7 @@ Shadow pages contain the following information: > > at __pa(sp2->spt). sp2 will point back at sp1 through parent_pte. > > The spt array forms a DAG structure with the shadow page as a node, and > > guest pages as leaves. > > - gfns: > > + shadowed_translation: > > An array of 512 guest frame numbers, one for each present pte. Used to > > guest frame numbers -> shadow translation info (gfn + access) Will add this one. I will avoid the "(gfn + access)" since that is already described in the comments inline and it may subject to changes, eg., adding more bits in the future. > > > perform a reverse map from a pte to a gfn. When role.direct is set, any > > Just "perform reverse mapping" is OK? I will tend to leave that as is, since it is not a major issue. > > > element of this array can be calculated from the gfn field when used, in > > May remove the "of gfns" will do. > > Thanks, > Yilun Thanks for the comment, will update it in next version. > > > -- > > 2.41.0.162.gfafddb0af9-goog > >
diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst index 561efa8ec7d7..149dd3cba48f 100644 --- a/Documentation/virt/kvm/x86/mmu.rst +++ b/Documentation/virt/kvm/x86/mmu.rst @@ -221,7 +221,7 @@ Shadow pages contain the following information: at __pa(sp2->spt). sp2 will point back at sp1 through parent_pte. The spt array forms a DAG structure with the shadow page as a node, and guest pages as leaves. - gfns: + shadowed_translation: An array of 512 guest frame numbers, one for each present pte. Used to perform a reverse map from a pte to a gfn. When role.direct is set, any element of this array can be calculated from the gfn field when used, in
Update the 'gfns' in kvm_mmu_page to 'shadowed_translation'to be consistent with the code. The more detailed description of 'shadowed_translation' is already inlined in the data structure definition, so no need to duplicate the text but simply just update the name. Signed-off-by: Mingwei Zhang <mizhang@google.com> --- Documentation/virt/kvm/x86/mmu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)