| Message ID | 20230622090634.3411468-1-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: Helper for deriving timeout values | expand |
Dne četrtek, 22. junij 2023 ob 11:06:31 CEST je Miquel Raynal napisal(a): > Hello, > > I recently came across an issue with the Atmel spi controller driver > which would stop my transfers after a too small timeout when performing > big transfers (reading a 4MiB flash in one transfer). My initial idea > was to derive a the maximum amount of time a transfer would take > depending on its size and use that as value to avoid erroring-out when > not relevant. Mark wanted to go further by creating a core helper doing > that, based on the heuristics from the sun6i driver. > > Here is a small series of 3 patches doing exactly that. > > Cheers, > Miquèl > > Changes in v3: > * Collected a tag. Did you? I don't see my a-b at patch 3. Best regards, Jernej > * As my platform runs on 6.1 currently, I cherry-picked a mainline patch > changing s/master/host/ in the atmel controller driver and modified the > series to fit the new naming. I then cherry-picked my three patches and > verified it compiled correctly against a v6.4-rc1. > > Miquel Raynal (3): > spi: Create a helper to derive adaptive timeouts > spi: atmel: Prevent false timeouts on long transfers > spi: sun6i: Use the new helper to derive the xfer timeout value > > drivers/spi/spi-atmel.c | 18 +++++++++++------- > drivers/spi/spi-sun6i.c | 2 +- > include/linux/spi/spi.h | 17 +++++++++++++++++ > 3 files changed, 29 insertions(+), 8 deletions(-) > >
Hi Jernej, jernej.skrabec@gmail.com wrote on Thu, 22 Jun 2023 18:46:27 +0200: > Dne četrtek, 22. junij 2023 ob 11:06:31 CEST je Miquel Raynal napisal(a): > > Hello, > > > > I recently came across an issue with the Atmel spi controller driver > > which would stop my transfers after a too small timeout when performing > > big transfers (reading a 4MiB flash in one transfer). My initial idea > > was to derive a the maximum amount of time a transfer would take > > depending on its size and use that as value to avoid erroring-out when > > not relevant. Mark wanted to go further by creating a core helper doing > > that, based on the heuristics from the sun6i driver. > > > > Here is a small series of 3 patches doing exactly that. > > > > Cheers, > > Miquèl > > > > Changes in v3: > > * Collected a tag. > > Did you? I don't see my a-b at patch 3. I thought I did, sorry if I missed it. Do you mind re-sending it? > > Best regards, > Jernej > > > * As my platform runs on 6.1 currently, I cherry-picked a mainline patch > > changing s/master/host/ in the atmel controller driver and modified the > > series to fit the new naming. I then cherry-picked my three patches and > > verified it compiled correctly against a v6.4-rc1. > > > > Miquel Raynal (3): > > spi: Create a helper to derive adaptive timeouts > > spi: atmel: Prevent false timeouts on long transfers > > spi: sun6i: Use the new helper to derive the xfer timeout value > > > > drivers/spi/spi-atmel.c | 18 +++++++++++------- > > drivers/spi/spi-sun6i.c | 2 +- > > include/linux/spi/spi.h | 17 +++++++++++++++++ > > 3 files changed, 29 insertions(+), 8 deletions(-) > > > > > > > > Thanks, Miquèl
On Thu, 22 Jun 2023 11:06:31 +0200, Miquel Raynal wrote: > I recently came across an issue with the Atmel spi controller driver > which would stop my transfers after a too small timeout when performing > big transfers (reading a 4MiB flash in one transfer). My initial idea > was to derive a the maximum amount of time a transfer would take > depending on its size and use that as value to avoid erroring-out when > not relevant. Mark wanted to go further by creating a core helper doing > that, based on the heuristics from the sun6i driver. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/3] spi: Create a helper to derive adaptive timeouts commit: d8e4ebf87018736c0c29e2eb4afe3915156483cd [2/3] spi: atmel: Prevent false timeouts on long transfers commit: e0205d6203c2ce598ae26d4b2707ca4224a9c90b [3/3] spi: sun6i: Use the new helper to derive the xfer timeout value commit: 6eef895581c9b5fcd002ff77837e0c3a4b1eecf6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark