| Message ID | 20230623113009.2512206-5-abel.vesa@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings | expand |
On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote: > The sm8450 has an ICE clock, so move the compatible to the proper > clocks check. > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230623113009.2512206-5-abel.vesa@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Jun 23, 2023 at 06:21:24AM -0600, Rob Herring wrote: > > On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote: > > The sm8450 has an ICE clock, so move the compatible to the proper > > clocks check. > > > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# Looks like patch 1 didn't apply for me and would fix this. Rob
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 4dad3f9ba81f..0209713d1f88 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -118,7 +118,6 @@ allOf: - qcom,sc8280xp-ufshc - qcom,sm8250-ufshc - qcom,sm8350-ufshc - - qcom,sm8450-ufshc - qcom,sm8550-ufshc then: properties: @@ -147,6 +146,7 @@ allOf: - qcom,sdm845-ufshc - qcom,sm6350-ufshc - qcom,sm8150-ufshc + - qcom,sm8450-ufshc then: properties: clocks:
The sm8450 has an ICE clock, so move the compatible to the proper clocks check. Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)