| Message ID | 20230623152518.8603-1-gcarlos@disroot.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tests: Fix swapped test parameter names | expand |
Hi Carlos! Em 23/06/2023 12:25, Carlos Eduardo Gallo Filho escreveu: > The "YVU420 DRM_MODE_FB_MODIFIERS set without modifier" test > hadn't DRM_MODE_FB_MODIFIERS set, so that it was in fact testing > another case, while the "YVU420 Normal sizes" test in turn was with > DRM_MODE_FB_MODIFIERS set and without modifiers, what should be > the case tested by the former, which also in turn fit in what > "YVU320 Normal sizes" should be, meaning that they were swapped. > I think the patch is simple enough to have a simple message, the diff itself tells a lot here. I would write something like this: drm/tests: Swap drm_framebuffer tests parameter names Swap tests parameters names so they actually reflect what is being tested. > Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org> Anyway, your version also works for me. Reviewed-by: André Almeida <andrealmeid@igalia.com> > --- > drivers/gpu/drm/tests/drm_framebuffer_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c > index df235b7fdaa5..f759d9f3b76e 100644 > --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c > +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c > @@ -178,13 +178,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = { > .handles = { 1, 1, 1 }, .pitches = { 600, 600, 600 }, > } > }, > -{ .buffer_created = 1, .name = "YVU420 Normal sizes", > +{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier", > .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420, > .handles = { 1, 1, 1 }, .flags = DRM_MODE_FB_MODIFIERS, > .pitches = { 600, 300, 300 }, > } > }, > -{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier", > +{ .buffer_created = 1, .name = "YVU420 Normal sizes", > .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420, > .handles = { 1, 1, 1 }, .pitches = { 600, 300, 300 }, > }
Hi Carlos, Great catch! On 6/23/23 12:25, Carlos Eduardo Gallo Filho wrote: > The "YVU420 DRM_MODE_FB_MODIFIERS set without modifier" test > hadn't DRM_MODE_FB_MODIFIERS set, so that it was in fact testing > another case, while the "YVU420 Normal sizes" test in turn was with > DRM_MODE_FB_MODIFIERS set and without modifiers, what should be > the case tested by the former, which also in turn fit in what > "YVU320 Normal sizes" should be, meaning that they were swapped. > > Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org> With André's comment addressed, Reviewed-by: Maíra Canal <mairacanal@riseup.net> Best Regards, - Maíra > --- > drivers/gpu/drm/tests/drm_framebuffer_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c > index df235b7fdaa5..f759d9f3b76e 100644 > --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c > +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c > @@ -178,13 +178,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = { > .handles = { 1, 1, 1 }, .pitches = { 600, 600, 600 }, > } > }, > -{ .buffer_created = 1, .name = "YVU420 Normal sizes", > +{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier", > .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420, > .handles = { 1, 1, 1 }, .flags = DRM_MODE_FB_MODIFIERS, > .pitches = { 600, 300, 300 }, > } > }, > -{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier", > +{ .buffer_created = 1, .name = "YVU420 Normal sizes", > .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420, > .handles = { 1, 1, 1 }, .pitches = { 600, 300, 300 }, > }
diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c index df235b7fdaa5..f759d9f3b76e 100644 --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c @@ -178,13 +178,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = { .handles = { 1, 1, 1 }, .pitches = { 600, 600, 600 }, } }, -{ .buffer_created = 1, .name = "YVU420 Normal sizes", +{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier", .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420, .handles = { 1, 1, 1 }, .flags = DRM_MODE_FB_MODIFIERS, .pitches = { 600, 300, 300 }, } }, -{ .buffer_created = 1, .name = "YVU420 DRM_MODE_FB_MODIFIERS set without modifier", +{ .buffer_created = 1, .name = "YVU420 Normal sizes", .cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_YVU420, .handles = { 1, 1, 1 }, .pitches = { 600, 300, 300 }, }
The "YVU420 DRM_MODE_FB_MODIFIERS set without modifier" test hadn't DRM_MODE_FB_MODIFIERS set, so that it was in fact testing another case, while the "YVU420 Normal sizes" test in turn was with DRM_MODE_FB_MODIFIERS set and without modifiers, what should be the case tested by the former, which also in turn fit in what "YVU320 Normal sizes" should be, meaning that they were swapped. Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org> --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)