diff mbox series

mmc: meson-gx: Drop redundant WARN_ON() in the irq handler

Message ID 20230622105327.77296-1-ulf.hansson@linaro.org (mailing list archive)
State New, archived
Headers show
Series mmc: meson-gx: Drop redundant WARN_ON() in the irq handler | expand

Commit Message

Ulf Hansson June 22, 2023, 10:53 a.m. UTC 
The host pointer is already being dereferenced earlier, so let's just drop
the redundant WARN_ON.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/mmc/host/meson-gx-mmc.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Martin Blumenstingl June 25, 2023, 8:47 p.m. UTC | #1 
On Thu, Jun 22, 2023 at 12:53 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> The host pointer is already being dereferenced earlier, so let's just drop
> the redundant WARN_ON.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
diff mbox series

Patch

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index ee9a25b900ae..d652374f37b2 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -948,9 +948,6 @@  static irqreturn_t meson_mmc_irq(int irq, void *dev_id)
 		return IRQ_NONE;
 	}
 
-	if (WARN_ON(!host))
-		return IRQ_NONE;
-
 	/* ack all raised interrupts */
 	writel(status, host->regs + SD_EMMC_STATUS);