| Message ID | 20230625204907.57291-5-julien@xen.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/arm: Enable UBSAN support | expand |
Hi Julien, > -----Original Message----- > Subject: [PATCH 4/9] xen/arm32: head: Remove 'r6' from the clobber list of > create_page_tables() > > From: Julien Grall <jgrall@amazon.com> > > Since commit 62529f16c8a2 ("xen/arm32: head: Use a page mapping for the > 1:1 mapping in create_page_tables()"), the register 'r6' is not used > anymore within create_page_tables(). So remove it from the documentation. > > Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry
On 25/06/2023 22:49, Julien Grall wrote: > > > From: Julien Grall <jgrall@amazon.com> > > Since commit 62529f16c8a2 ("xen/arm32: head: Use a page mapping for the > 1:1 mapping in create_page_tables()"), the register 'r6' is not used > anymore within create_page_tables(). So remove it from the documentation. > > Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Michal Orzel <michal.orzel@amd.com> ~Michal
Hi Julien, > On 25 Jun 2023, at 22:49, Julien Grall <julien@xen.org> wrote: > > From: Julien Grall <jgrall@amazon.com> > > Since commit 62529f16c8a2 ("xen/arm32: head: Use a page mapping for the > 1:1 mapping in create_page_tables()"), the register 'r6' is not used > anymore within create_page_tables(). So remove it from the documentation. > > Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> Cheers Bertrand > --- > xen/arch/arm/arm32/head.S | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index 997c8a4fbbc1..5e3692eb3abf 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -451,10 +451,7 @@ ENDPROC(cpu_init) > * Output: > * r12: Was a temporary mapping created? > * > - * Clobbers r0 - r4, r6 > - * > - * Register usage within this function: > - * r6 : Identity map in place > + * Clobbers r0 - r4 > */ > create_page_tables: > /* Prepare the page-tables for mapping Xen */ > -- > 2.40.1 >
diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 997c8a4fbbc1..5e3692eb3abf 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -451,10 +451,7 @@ ENDPROC(cpu_init) * Output: * r12: Was a temporary mapping created? * - * Clobbers r0 - r4, r6 - * - * Register usage within this function: - * r6 : Identity map in place + * Clobbers r0 - r4 */ create_page_tables: /* Prepare the page-tables for mapping Xen */