| Message ID | 20221209-dt-binding-ufs-v4-2-14ced60f3d1b@fairphone.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix some issues in QCOM UFS bindings | expand |
On 26/06/2023 10:15, Luca Weiss wrote: > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > in the bindings so the existing dts can validate successfully. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Eric Biggers <ebiggers@google.com> > Reviewed-by: Iskren Chernev <me@iskren.info> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index eb3de2fde6b0..b5fc686cb3a1 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -80,6 +80,10 @@ properties: > minItems: 1 > maxItems: 2 > > + reg-names: > + minItems: 1 > + maxItems: 2 > + > required-opps: > maxItems: 1 > > @@ -135,6 +139,8 @@ allOf: > reg: > minItems: 1 > maxItems: 1 > + reg-names: > + maxItems: 1 I see I reviewed, but I don't think the patch is correct. It allows any reg-names. I think my advice from v1 was not understood. The names should be defined in top-level. Best regards, Krzysztof
On Mon Jun 26, 2023 at 10:26 AM CEST, Krzysztof Kozlowski wrote: > On 26/06/2023 10:15, Luca Weiss wrote: > > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > > in the bindings so the existing dts can validate successfully. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Eric Biggers <ebiggers@google.com> > > Reviewed-by: Iskren Chernev <me@iskren.info> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > index eb3de2fde6b0..b5fc686cb3a1 100644 > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > @@ -80,6 +80,10 @@ properties: > > minItems: 1 > > maxItems: 2 > > > > + reg-names: > > + minItems: 1 > > + maxItems: 2 > > + > > required-opps: > > maxItems: 1 > > > > @@ -135,6 +139,8 @@ allOf: > > reg: > > minItems: 1 > > maxItems: 1 > > + reg-names: > > + maxItems: 1 > > I see I reviewed, but I don't think the patch is correct. It allows any > reg-names. I think my advice from v1 was not understood. The names > should be defined in top-level. Thanks for your review, I hope it's resolved in v5 of this series. Please check :) Regards Luca > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index eb3de2fde6b0..b5fc686cb3a1 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -80,6 +80,10 @@ properties: minItems: 1 maxItems: 2 + reg-names: + minItems: 1 + maxItems: 2 + required-opps: maxItems: 1 @@ -135,6 +139,8 @@ allOf: reg: minItems: 1 maxItems: 1 + reg-names: + maxItems: 1 - if: properties: @@ -163,6 +169,12 @@ allOf: reg: minItems: 2 maxItems: 2 + reg-names: + items: + - const: std + - const: ice + required: + - reg-names - if: properties: @@ -191,6 +203,8 @@ allOf: reg: minItems: 1 maxItems: 1 + reg-names: + maxItems: 1 - if: properties: @@ -216,6 +230,12 @@ allOf: reg: minItems: 2 maxItems: 2 + reg-names: + items: + - const: std + - const: ice + required: + - reg-names # TODO: define clock bindings for qcom,msm8994-ufshc