| Message ID | 20230627064948.593804-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (pmbus) Update documentation to not use .probe_new() any more | expand |
Hi Uwe, On 6/26/23 23:49, Uwe Kleine-König wrote: > Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id > parameter") .probe() is the recommended callback to implement an i2c > driver (again). Reflect this in the documentation and don't mention > .probe_new() which will be dropped soon. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > this patch was part of a patch dropping .probe_new() before (see > https://lore.kernel.org/linux-i2c/20230626094548.559542-1-u.kleine-koenig@pengutronix.de). > > However this change makes already sense without dropping .probe_new, so > here it comes as a separate patch. > > Best regards > Uwe > I got this after sending my pull request, and I don't currently plan to send another one. What is the time line for the probe_new removal ? If it is still planned for 6.5, you might want to keep it as part of the series. In that case, Acked-by: Guenter Roeck <linux@roeck-us.net> Thanks, Guenter > Documentation/hwmon/pmbus.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/hwmon/pmbus.rst b/Documentation/hwmon/pmbus.rst > index 7ecfec6ca2db..eb1569bfa676 100644 > --- a/Documentation/hwmon/pmbus.rst > +++ b/Documentation/hwmon/pmbus.rst > @@ -163,7 +163,7 @@ Emerson DS1200 power modules might look as follows:: > .driver = { > .name = "ds1200", > }, > - .probe_new = ds1200_probe, > + .probe = ds1200_probe, > .id_table = ds1200_id, > }; > > > base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1
Hello Guenter, On Wed, Jun 28, 2023 at 09:46:26AM -0700, Guenter Roeck wrote: > On 6/26/23 23:49, Uwe Kleine-König wrote: > > Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id > > parameter") .probe() is the recommended callback to implement an i2c > > driver (again). Reflect this in the documentation and don't mention > > .probe_new() which will be dropped soon. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > this patch was part of a patch dropping .probe_new() before (see > > https://lore.kernel.org/linux-i2c/20230626094548.559542-1-u.kleine-koenig@pengutronix.de). > > > > However this change makes already sense without dropping .probe_new, so > > here it comes as a separate patch. > > I got this after sending my pull request, and I don't currently plan to send > another one. What is the time line for the probe_new removal ? If it is > still planned for 6.5, you might want to keep it as part of the series. > In that case, > > Acked-by: Guenter Roeck <linux@roeck-us.net> Getting this final patch into next after 6.5-rc1 was my initial plan, but on Monday I found a few newly introduced users of .probe_new(). Patches were send out, but I intend to postpone by one release cycle. So if you take it during the merge window for 6.6-rc1 that's fine. Thanks for your cooperation, very appreciated! Best regards Uwe
On 6/28/23 13:00, Uwe Kleine-König wrote: > Hello Guenter, > > On Wed, Jun 28, 2023 at 09:46:26AM -0700, Guenter Roeck wrote: >> On 6/26/23 23:49, Uwe Kleine-König wrote: >>> Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id >>> parameter") .probe() is the recommended callback to implement an i2c >>> driver (again). Reflect this in the documentation and don't mention >>> .probe_new() which will be dropped soon. >>> >>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >>> --- >>> Hello, >>> >>> this patch was part of a patch dropping .probe_new() before (see >>> https://lore.kernel.org/linux-i2c/20230626094548.559542-1-u.kleine-koenig@pengutronix.de). >>> >>> However this change makes already sense without dropping .probe_new, so >>> here it comes as a separate patch. >> >> I got this after sending my pull request, and I don't currently plan to send >> another one. What is the time line for the probe_new removal ? If it is >> still planned for 6.5, you might want to keep it as part of the series. >> In that case, >> >> Acked-by: Guenter Roeck <linux@roeck-us.net> > > Getting this final patch into next after 6.5-rc1 was my initial plan, > but on Monday I found a few newly introduced users of .probe_new(). > Patches were send out, but I intend to postpone by one release cycle. So > if you take it during the merge window for 6.6-rc1 that's fine. > Sure, no problem. Guenter
diff --git a/Documentation/hwmon/pmbus.rst b/Documentation/hwmon/pmbus.rst index 7ecfec6ca2db..eb1569bfa676 100644 --- a/Documentation/hwmon/pmbus.rst +++ b/Documentation/hwmon/pmbus.rst @@ -163,7 +163,7 @@ Emerson DS1200 power modules might look as follows:: .driver = { .name = "ds1200", }, - .probe_new = ds1200_probe, + .probe = ds1200_probe, .id_table = ds1200_id, };
Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") .probe() is the recommended callback to implement an i2c driver (again). Reflect this in the documentation and don't mention .probe_new() which will be dropped soon. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, this patch was part of a patch dropping .probe_new() before (see https://lore.kernel.org/linux-i2c/20230626094548.559542-1-u.kleine-koenig@pengutronix.de). However this change makes already sense without dropping .probe_new, so here it comes as a separate patch. Best regards Uwe Documentation/hwmon/pmbus.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1