| Message ID | 20230629104603.88612-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: rt5677: Refactor to use device_get_match_data() | expand |
On Thu, Jun 29, 2023 at 01:46:01PM +0300, Andy Shevchenko wrote: > Instead of irq_domain_add_linear() that requires of_node, > use irq_domain_create_linear() that works outside of OF world. ... > - rt5677->domain = irq_domain_add_linear(i2c->dev.of_node, > + rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev), > RT5677_IRQ_NUM, &rt5677_domain_ops, rt5677); Oops, this won't compile :-( Seems I tried in another branch that has this module disabled. > if (!rt5677->domain) { > dev_err(&i2c->dev, "Failed to create IRQ domain\n");
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on linus/master v6.4 next-20230629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ASoC-rt5677-Use-agnostic-irq_domain_create_linear/20230629-184911
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20230629104603.88612-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/3] ASoC: rt5677: Use agnostic irq_domain_create_linear()
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230630/202306300102.yMAJ3kZt-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230630/202306300102.yMAJ3kZt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306300102.yMAJ3kZt-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/acpi.h:16,
from sound/soc/codecs/rt5677.c:9:
sound/soc/codecs/rt5677.c: In function 'rt5677_init_irq':
>> include/linux/property.h:38:18: error: '_Generic' selector of type 'struct device' is not compatible with any association
38 | _Generic((dev), \
| ^
sound/soc/codecs/rt5677.c:5542:51: note: in expansion of macro 'dev_fwnode'
5542 | rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev),
| ^~~~~~~~~~
vim +38 include/linux/property.h
1b9863c6aa56d9 Suthikulpanit, Suravee 2015-10-28 34
b295d484b97081 Andy Shevchenko 2022-10-04 35 const struct fwnode_handle *__dev_fwnode_const(const struct device *dev);
b295d484b97081 Andy Shevchenko 2022-10-04 36 struct fwnode_handle *__dev_fwnode(struct device *dev);
b295d484b97081 Andy Shevchenko 2022-10-04 37 #define dev_fwnode(dev) \
b295d484b97081 Andy Shevchenko 2022-10-04 @38 _Generic((dev), \
b295d484b97081 Andy Shevchenko 2022-10-04 39 const struct device *: __dev_fwnode_const, \
b295d484b97081 Andy Shevchenko 2022-10-04 40 struct device *: __dev_fwnode)(dev)
e44bb0cbdc8868 Sakari Ailus 2017-03-28 41
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index ad14d18860fc..4ef9c88cb20a 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5539,7 +5539,7 @@ static int rt5677_init_irq(struct i2c_client *i2c) RT5677_GPIO1_PIN_MASK, RT5677_GPIO1_PIN_IRQ); /* Ready to listen for interrupts */ - rt5677->domain = irq_domain_add_linear(i2c->dev.of_node, + rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev), RT5677_IRQ_NUM, &rt5677_domain_ops, rt5677); if (!rt5677->domain) { dev_err(&i2c->dev, "Failed to create IRQ domain\n");
Instead of irq_domain_add_linear() that requires of_node, use irq_domain_create_linear() that works outside of OF world. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)