mbox series

[v2,0/4] trace-cmd record: Improvements to --daemonize option

Message ID 20230626091635.3002827-1-avidanborisov@gmail.com (mailing list archive)
Headers show
Series trace-cmd record: Improvements to --daemonize option | expand

Message

avidanborisov@gmail.com June 26, 2023, 9:16 a.m. UTC
From: Avidan Borisov <avidanborisov@gmail.com>

Hi Steven,

This is the second version of my patch series for adding the --daemonize option to trace-cmd record, incorporating your feedback.

Changes since v1:
- Replaced all instances of "he" with "the user".
- Fixed the issue with the `break` statement in the switch case.
- Added a usage example of --daemonize to the man page.

Let me know if there are any further changes required.

Thanks,
Avidan

Avidan Borisov (4):
  trace-cmd record: Add --daemonize
  trace-cmd: export pidfile functions from trace-listen.c
  trace-cmd record: Create a pidfile when using --daemonize
  trace-cmd record: Add --daemonize example to man page

 .../trace-cmd/trace-cmd-record.1.txt          |  33 ++++
 tracecmd/include/trace-local.h                |   4 +
 tracecmd/trace-listen.c                       |  32 ++--
 tracecmd/trace-record.c                       | 142 +++++++++++++++++-
 tracecmd/trace-usage.c                        |   3 +
 5 files changed, 194 insertions(+), 20 deletions(-)

Comments

Steven Rostedt July 2, 2023, 1:39 a.m. UTC | #1
On Mon, 26 Jun 2023 12:16:31 +0300
avidanborisov@gmail.com wrote:

> From: Avidan Borisov <avidanborisov@gmail.com>
> 
> Hi Steven,

Thanks Avidan,

I'm currently traveling and then we have two US holidays for Monday and
Tuesday, I'll try to get to it within a week or two.

Also, when sending a v2, please make it a new thread and do not reply
to the previous version. It makes it more visible, otherwise, the
second version gets lost in the thread of the first.

Thanks,

-- Steve


> 
> This is the second version of my patch series for adding the --daemonize option to trace-cmd record, incorporating your feedback.
> 
> Changes since v1:
> - Replaced all instances of "he" with "the user".
> - Fixed the issue with the `break` statement in the switch case.
> - Added a usage example of --daemonize to the man page.
> 
> Let me know if there are any further changes required.
> 
> Thanks,
> Avidan
> 
> Avidan Borisov (4):
>   trace-cmd record: Add --daemonize
>   trace-cmd: export pidfile functions from trace-listen.c
>   trace-cmd record: Create a pidfile when using --daemonize
>   trace-cmd record: Add --daemonize example to man page
> 
>  .../trace-cmd/trace-cmd-record.1.txt          |  33 ++++
>  tracecmd/include/trace-local.h                |   4 +
>  tracecmd/trace-listen.c                       |  32 ++--
>  tracecmd/trace-record.c                       | 142 +++++++++++++++++-
>  tracecmd/trace-usage.c                        |   3 +
>  5 files changed, 194 insertions(+), 20 deletions(-)
>