| Message ID | 20230628151623.11340-1-dwagner@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | More fixes for FC enabling | expand |
On Jun 28, 2023 / 17:16, Daniel Wagner wrote: > I (think) address all the feedback I got from Sagi and Shinichiro except one. > The _have_nvme_cli_context() (previously _nvme_cli_support_context()) function > is still there. I didn't find any other good way to achieve this and I found in > blktests another function doing the same: _have_fio_zbd_zonemode(). I found that the latest blktests fix for the hostnqn/hostid issue created conflict with the 2nd patch in this series. Sorry about that. (Actually, I guess this series could be enough for the issue...) Daniel, I can fix the conflict and repost the series to the list. Or you can fix the conflict by yourself. Please let me know your preference. Other than that, I think the three patches are good enough to apply.
On Mon, Jul 03, 2023 at 05:43:01AM +0000, Shinichiro Kawasaki wrote: > On Jun 28, 2023 / 17:16, Daniel Wagner wrote: > > I (think) address all the feedback I got from Sagi and Shinichiro except one. > > The _have_nvme_cli_context() (previously _nvme_cli_support_context()) function > > is still there. I didn't find any other good way to achieve this and I found in > > blktests another function doing the same: _have_fio_zbd_zonemode(). > > I found that the latest blktests fix for the hostnqn/hostid issue created > conflict with the 2nd patch in this series. Sorry about that. (Actually, I guess > this series could be enough for the issue...) No problem. > Daniel, I can fix the conflict and repost the series to the list. Or you can fix > the conflict by yourself. Please let me know your preference. I'll rebase and fixup the conflict. Also give it another quick test run just to make sure all still works. > Other than that, I think the three patches are good enough to apply. Great!
I (think) address all the feedback I got from Sagi and Shinichiro except one. The _have_nvme_cli_context() (previously _nvme_cli_support_context()) function is still there. I didn't find any other good way to achieve this and I found in blktests another function doing the same: _have_fio_zbd_zonemode(). Daniel changes: v2: - nvme/048: - untaggle waiting for state change and queue count check - make all variables local - compare numbers not strings - nvme/rc: - rename _nvme_cli_supports_context to _have_nvme_cli_context - only add --context for fc - reordered setup/cleanup - nvme/{041,042,043,044,045,048}: - move all changes related to this patch v1: - https://lore.kernel.org/linux-nvme/20230620132703.20648-1-dwagner@suse.de/ Daniel Wagner (3): nvme/048: Check for queue count check directly nvme/rc: Avoid triggering host nvme-cli autoconnect nvme/{041,042,043,044,045,048}: Use default hostnqn and hostid tests/nvme/041 | 8 ++--- tests/nvme/042 | 8 ++--- tests/nvme/043 | 8 ++--- tests/nvme/044 | 8 ++--- tests/nvme/045 | 8 ++--- tests/nvme/048 | 32 +++++++++++++------- tests/nvme/rc | 81 +++++++++++++++++++++++++++++++++++++++++++------- 7 files changed, 103 insertions(+), 50 deletions(-)